Support promise-like types in contextual return type of async function#27256
Closed
rbuckton wants to merge 3 commits intorelease-3.1from
Closed
Support promise-like types in contextual return type of async function#27256rbuckton wants to merge 3 commits intorelease-3.1from
rbuckton wants to merge 3 commits intorelease-3.1from
Conversation
Contributor
Author
|
@weswigham: I opted to just continue using |
Member
|
Does this fix #27001 too? |
Contributor
Author
|
@DanielRosenwasser: I don't think it does, but I will check that tomorrow. |
weswigham
approved these changes
Sep 21, 2018
Contributor
Author
|
@DanielRosenwasser: It does now, the fix for #27001 was easy to accomplish with the changes in this PR since you need the same behavior (union the awaited type with a |
Contributor
Author
|
This change is postponed to 3.2, you can find the PR against master here: #27270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the contextual type we use for a return expression in an async function. Prior to this change, we would infer
{}for the type argument toPromisebelow:This is because we use the "awaited type"
Objfor the return typePromise<Obj>as the contextual type. With this change, we useObj | PromiseLike<Obj>as the contextual type:Fixes #24629, #27001