Free up space in the TransformFlags enum#27410
Merged
Conversation
ghost
approved these changes
Sep 28, 2018
| const hasParameterPropertyAssignments = node.transformFlags & TransformFlags.ContainsParameterPropertyAssignments; | ||
| const constructor = getFirstConstructorWithBody(node); | ||
| const hasInstancePropertyWithInitializer = forEach(node.members, isInstanceInitializedProperty); | ||
| const hasParameterPropertyAssignments = constructor && |
Contributor
Author
There was a problem hiding this comment.
How is it no longer accurate? It is checking the same thing.
There was a problem hiding this comment.
I thought this would now trigger if any TS features were used inside it, not just parameter property assignments.
RyanCavanaugh
approved these changes
Oct 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR frees up a few bits in the
TransformFlagsenum to allow room for more edition-specific flags. This is needed to support an ES2018 transform, such as in #26315.It also contains a small fix for out up-to-date checks in the gulp builds, as they will break if we update LKG in master due to API changes.