Remove the rule that replaces a union of literal types with the base type when comparing equality to a type that isn't a union of literal types.#27588
Merged
RyanCavanaugh merged 1 commit intomicrosoft:masterfrom Apr 23, 2019
Conversation
Member
|
@mattmccutchen I think this is good to merge once the merge conflict is resolved. Sorry for the delay |
type when comparing equality to a type that isn't a union of literal types. The rule is redundant because a primitive type is already directed- comparable to a value of that primitive type, and it causes errors to be missed when comparing a type parameter _constrained_ by a union of literal types to another union of literal types. The baseline changes look like improvements to me. Fixes microsoft#26758.
mattmccutchen
force-pushed
the
issue-26758
branch
from
d1325f1 to
112fa23
Compare
Contributor
Author
|
Updated to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule is redundant because a primitive type is already directed-
comparable to a value of that primitive type, and it causes errors to be
missed when comparing a type parameter constrained by a union of
literal types to another union of literal types.
The baseline changes look like improvements to me.
Fixes #26758.