Only suggest adding to types if present in compilerOptions#28240
Merged
Conversation
RyanCavanaugh
approved these changes
Jan 24, 2019
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
LGTM after the diagnostics merge conflict gets taken care of. Thanks!
Member
|
@ajafff sorry, keeping merge conflicts out of diagnosticMessages is an enormous pain and something went in ahead of you this morning. Can you keep trying? |
Member
|
Thank you for being persistent and patient with this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #28211 (comment)
This change doesn't contain a specific message for the case where
typeRootsis present. I just couldn't come up with a good text.I don't like copying those diagnostics. Does it make sense to add the second part of the text as related diagnostic similar to
It is highly likely that you are missing a semicolon.?