fix name lookup change again#28501
Closed
Kingwl wants to merge 3 commits intomicrosoft:masterfrom
Closed
Conversation
Contributor
Author
|
something seems wrong, i'll fix that later |
ajafff
suggested changes
Nov 13, 2018
| let bazzzz = 2; | ||
| function f9(bar = () => bazzzz) { | ||
| ~~~~~~ | ||
| !!! error TS2373: Initializer of parameter 'bar' cannot reference identifier 'bazzzz' declared after it. |
Contributor
There was a problem hiding this comment.
why is this error here? It doesn't reference the inner var bazzzz (var doesn't work any different than let and const in this case). And the outer let bazzzz is definitely not declared after the parameter.
Contributor
Author
function bar(func = () => foo) {
let foo = "in";
return func
}to function bar(func) {
if (func === void 0) { func = function () { return foo; }; }
var foo = "in";
return func;
}and the result is |
Contributor
Author
|
seems that is not a bug? @weswigham |
Member
|
Yeah, I'm pretty sure that error reflects the behavior of our actual down level emit rather than the spec. |
Contributor
Author
|
🤷🏻♂️ awesome emit |
096eedf to
0f21db3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28474