getEffectiveBaseTypeNode: only use JSDoc augments if there is extends#29349
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Feb 5, 2019
Merged
getEffectiveBaseTypeNode: only use JSDoc augments if there is extends#29349sandersn merged 1 commit intomicrosoft:masterfrom
sandersn merged 1 commit intomicrosoft:masterfrom
Conversation
| export function getEffectiveBaseTypeNode(node: ClassLikeDeclaration | InterfaceDeclaration) { | ||
| if (isInJSFile(node)) { | ||
| const baseType = getClassExtendsHeritageElement(node); | ||
| if (baseType && isInJSFile(node)) { |
Member
There was a problem hiding this comment.
@DanielRosenwasser @sandersn should it be error to have augments clause and not have extends clause?
Member
There was a problem hiding this comment.
I think it would be too noisy. Every time we add errors like this they add noise to erroneous jsdoc -- ones where people weren't actually using the jsdoc and didn't want to.
sandersn
approved these changes
Feb 5, 2019
| export function getEffectiveBaseTypeNode(node: ClassLikeDeclaration | InterfaceDeclaration) { | ||
| if (isInJSFile(node)) { | ||
| const baseType = getClassExtendsHeritageElement(node); | ||
| if (baseType && isInJSFile(node)) { |
Member
There was a problem hiding this comment.
I think it would be too noisy. Every time we add errors like this they add noise to erroneous jsdoc -- ones where people weren't actually using the jsdoc and didn't want to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @sandersn in #29308 (comment)