rescan in formatter if followed unary literal#29492
Closed
Kingwl wants to merge 2 commits intomicrosoft:masterfrom
Closed
rescan in formatter if followed unary literal#29492Kingwl wants to merge 2 commits intomicrosoft:masterfrom
Kingwl wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Member
|
@sandersn is this the right approach? |
Member
|
I think in general, instead of rescanning numeric literal, we usually handle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29330
after track,I found the reason of the assert failed caused the
-1has been scanned asprefixUnaryExpression -> Numeric Literal, i have rescan the literal and merge the prefix expression and number literal to a signal literal