Avoid unnecessary type assertions in module resolution code#31238
Closed
ajafff wants to merge 1 commit intomicrosoft:masterfrom
Closed
Avoid unnecessary type assertions in module resolution code#31238ajafff wants to merge 1 commit intomicrosoft:masterfrom
ajafff wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Member
|
I don't think we want to break API at this point.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #18217
Note that this changes the public API of
CompilerHost#resolveModuleNames. The Host is expected to returnResolvedModuleFull, but there is some compatibility code for "older" hosts. That code is still there, but if you compile your "older host" with a new version of TypeScript, you will get a type error if you only returnResolvedModule.I could revert that particular change if you are not comfortable with it.