Simplify conditionals upon comparison, rather than instantiation#31374
Merged
ahejlsberg merged 1 commit intomicrosoft:deferConditionalTypesfrom May 13, 2019
Conversation
Member
|
I was about to commit a very similar change to my PR. I also removed the root-based simplifications from |
Member
Author
The only real difference should be in alias symbols - by deferring all simplifications we guarantee that the conditional keeps it's alias, even if it simplifies (since its identity still exists). It's arguably better that way, so yeah, could do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional work on top of #31354 to retain our better simplification behavior (this is currently set to merge into that PR).
styled-componentson #31354:This PR:
completionEntryDetailstyping delay (via repro from #31302) I sampled at 211ms on #31354 as-is, with this PR I sampled 147ms.