Cache widened types by weswigham · Pull Request #31586 · microsoft/TypeScript

weswigham · 2019-05-24T22:09:45Z

Probably fixes #29564 (doesn't have a full repro)

Notably does not fix #29597 - that has some more stuff going on - chart.min.js is uuuuuuge.

weswigham · 2019-05-24T22:12:31Z

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

typescript-bot · 2019-05-24T22:12:32Z

Heya @weswigham, I've started to run the extended test suite on this PR at 440cc7f. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-05-24T22:12:32Z

Heya @weswigham, I've started to run the community code test suite on this PR at 440cc7f. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-05-24T22:12:33Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 440cc7f. You can monitor the build here. It should now contribute to this PR's status checks.

weswigham · 2019-05-24T22:42:48Z

@typescript-bot test this now that that lint is fixed 🤦‍♂

typescript-bot · 2019-05-24T22:42:49Z

Heya @weswigham, I've started to run the extended test suite on this PR at 2a25fc7. You can monitor the build here. It should now contribute to this PR's status checks.

weswigham · 2019-05-24T23:04:17Z

DT passes, as expected 🌞

weswigham · 2019-05-24T23:33:31Z

@RyanCavanaugh All the test suites are gucci

weswigham · 2019-05-28T18:01:08Z

@typescript-bot perf test this - this should make for some perf gains, even in older style code (but moreso in JS).

typescript-bot · 2019-05-28T18:01:11Z

Heya @weswigham, I've started to run the perf test suite on this PR at 2a25fc7. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

typescript-bot · 2019-05-28T18:48:16Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..31586

Metric	master	31586	Delta	Best	Worst
Angular - node (v12.1.0, x64)
Memory used	314,992k (± 0.04%)	315,006k (± 0.02%)	+14k (+ 0.00%)	314,827k	315,161k
Parse Time	1.38s (± 0.58%)	1.39s (± 0.47%)	+0.01s (+ 0.73%)	1.37s	1.40s
Bind Time	0.73s (± 1.06%)	0.73s (± 0.76%)	-0.00s (- 0.41%)	0.72s	0.74s
Check Time	4.10s (± 0.42%)	4.03s (± 0.49%)	-0.07s (- 1.66%)	3.99s	4.08s
Emit Time	5.14s (± 0.63%)	5.09s (± 0.42%)	-0.05s (- 0.93%)	5.06s	5.16s
Total Time	11.35s (± 0.42%)	11.24s (± 0.30%)	-0.11s (- 0.97%)	11.16s	11.31s
Monaco - node (v12.1.0, x64)
Memory used	343,905k (± 0.02%)	343,750k (± 0.01%)	-155k (- 0.05%)	343,641k	343,846k
Parse Time	1.18s (± 0.78%)	1.18s (± 0.84%)	-0.00s (- 0.34%)	1.16s	1.20s
Bind Time	0.67s (± 0.74%)	0.67s (± 0.50%)	+0.00s (+ 0.60%)	0.66s	0.68s
Check Time	4.18s (± 0.52%)	4.16s (± 0.73%)	-0.02s (- 0.60%)	4.09s	4.21s
Emit Time	2.77s (± 0.53%)	2.77s (± 0.66%)	-0.01s (- 0.22%)	2.74s	2.82s
Total Time	8.80s (± 0.35%)	8.77s (± 0.49%)	-0.03s (- 0.32%)	8.68s	8.87s
TFS - node (v12.1.0, x64)
Memory used	300,839k (± 0.02%)	300,793k (± 0.02%)	-46k (- 0.02%)	300,668k	300,966k
Parse Time	0.91s (± 0.66%)	0.91s (± 0.85%)	+0.00s (+ 0.33%)	0.90s	0.93s
Bind Time	0.61s (± 0.56%)	0.62s (± 0.90%)	+0.01s (+ 0.82%)	0.61s	0.63s
Check Time	3.75s (± 0.53%)	3.74s (± 0.62%)	-0.01s (- 0.27%)	3.66s	3.78s
Emit Time	2.85s (± 0.99%)	2.86s (± 0.76%)	+0.01s (+ 0.18%)	2.80s	2.89s
Total Time	8.11s (± 0.59%)	8.12s (± 0.53%)	+0.01s (+ 0.07%)	8.02s	8.20s
Angular - node (v8.9.0, x64)
Memory used	332,990k (± 0.01%)	332,985k (± 0.02%)	-5k (- 0.00%)	332,845k	333,066k
Parse Time	1.77s (± 0.50%)	1.77s (± 0.59%)	+0.00s (+ 0.11%)	1.76s	1.80s
Bind Time	0.78s (± 0.61%)	0.79s (± 0.87%)	+0.00s (+ 0.26%)	0.77s	0.80s
Check Time	4.81s (± 1.42%)	4.76s (± 1.56%)	-0.06s (- 1.20%)	4.63s	4.88s
Emit Time	5.84s (± 3.20%)	5.87s (± 3.30%)	+0.03s (+ 0.46%)	5.39s	6.24s
Total Time	13.21s (± 1.04%)	13.19s (± 1.21%)	-0.02s (- 0.16%)	12.82s	13.56s
Monaco - node (v8.9.0, x64)
Memory used	360,933k (± 0.03%)	361,013k (± 0.02%)	+80k (+ 0.02%)	360,911k	361,128k
Parse Time	1.43s (± 0.53%)	1.43s (± 0.70%)	-0.00s (- 0.00%)	1.41s	1.46s
Bind Time	0.92s (± 1.71%)	0.89s (± 2.37%)	-0.02s (- 2.62%)	0.86s	0.93s
Check Time	4.97s (± 1.55%)	5.00s (± 1.54%)	+0.04s (+ 0.74%)	4.86s	5.12s
Emit Time	3.29s (± 4.98%)	3.07s (± 7.38%)	-0.22s (- 6.78%)	2.80s	3.50s
Total Time	10.60s (± 1.02%)	10.39s (± 1.70%)	-0.21s (- 1.97%)	10.15s	10.80s
TFS - node (v8.9.0, x64)
Memory used	316,292k (± 0.02%)	316,337k (± 0.02%)	+44k (+ 0.01%)	316,210k	316,431k
Parse Time	1.14s (± 0.73%)	1.14s (± 0.73%)	0.00s ( 0.00%)	1.12s	1.16s
Bind Time	0.66s (± 1.01%)	0.66s (± 0.93%)	-0.00s (- 0.30%)	0.65s	0.68s
Check Time	4.34s (± 0.40%)	4.32s (± 0.71%)	-0.02s (- 0.39%)	4.27s	4.39s
Emit Time	3.12s (± 0.63%)	3.15s (± 0.38%)	+0.03s (+ 0.83%)	3.11s	3.17s
Total Time	9.25s (± 0.26%)	9.26s (± 0.43%)	+0.01s (+ 0.14%)	9.20s	9.36s
Angular - node (v8.9.0, x86)
Memory used	188,649k (± 0.02%)	188,605k (± 0.02%)	-44k (- 0.02%)	188,521k	188,683k
Parse Time	1.72s (± 1.08%)	1.73s (± 0.62%)	+0.01s (+ 0.46%)	1.71s	1.75s
Bind Time	0.93s (± 0.53%)	0.94s (± 0.36%)	+0.00s (+ 0.32%)	0.93s	0.94s
Check Time	4.41s (± 0.36%)	4.40s (± 0.57%)	-0.01s (- 0.16%)	4.35s	4.46s
Emit Time	5.64s (± 1.00%)	5.68s (± 0.86%)	+0.04s (+ 0.71%)	5.55s	5.76s
Total Time	12.71s (± 0.39%)	12.75s (± 0.43%)	+0.04s (+ 0.34%)	12.60s	12.84s
Monaco - node (v8.9.0, x86)
Memory used	201,332k (± 0.02%)	201,382k (± 0.02%)	+51k (+ 0.03%)	201,318k	201,445k
Parse Time	1.49s (± 0.96%)	1.49s (± 0.60%)	-0.00s (- 0.27%)	1.47s	1.51s
Bind Time	0.71s (± 0.56%)	0.72s (± 1.41%)	+0.01s (+ 0.99%)	0.70s	0.75s
Check Time	4.77s (± 0.62%)	4.73s (± 0.32%)	-0.04s (- 0.86%)	4.69s	4.76s
Emit Time	3.08s (± 0.43%)	3.08s (± 0.40%)	-0.01s (- 0.23%)	3.04s	3.10s
Total Time	10.05s (± 0.30%)	10.00s (± 0.25%)	-0.05s (- 0.45%)	9.94s	10.07s
TFS - node (v8.9.0, x86)
Memory used	177,441k (± 0.02%)	177,449k (± 0.02%)	+7k (+ 0.00%)	177,370k	177,536k
Parse Time	1.19s (± 0.50%)	1.20s (± 1.12%)	+0.00s (+ 0.17%)	1.17s	1.23s
Bind Time	0.63s (± 0.76%)	0.63s (± 0.79%)	-0.00s (- 0.16%)	0.62s	0.64s
Check Time	4.16s (± 0.47%)	4.15s (± 0.39%)	-0.01s (- 0.36%)	4.10s	4.18s
Emit Time	2.80s (± 1.69%)	2.76s (± 0.71%)	-0.04s (- 1.43%)	2.73s	2.81s
Total Time	8.78s (± 0.56%)	8.73s (± 0.37%)	-0.06s (- 0.64%)	8.62s	8.79s
Angular - node (v9.0.0, x64)
Memory used	332,869k (± 0.01%)	332,835k (± 0.04%)	-34k (- 0.01%)	332,581k	333,191k
Parse Time	1.61s (± 0.59%)	1.61s (± 0.37%)	0.00s ( 0.00%)	1.60s	1.62s
Bind Time	0.74s (± 0.40%)	0.74s (± 0.30%)	+0.00s (+ 0.14%)	0.73s	0.74s
Check Time	4.46s (± 1.62%)	4.40s (± 0.65%)	-0.06s (- 1.26%)	4.34s	4.49s
Emit Time	5.62s (± 2.21%)	5.74s (± 1.55%)	+0.12s (+ 2.10%)	5.63s	5.93s
Total Time	12.43s (± 0.62%)	12.50s (± 0.76%)	+0.06s (+ 0.51%)	12.35s	12.70s
Monaco - node (v9.0.0, x64)
Memory used	360,804k (± 0.01%)	360,678k (± 0.04%)	-126k (- 0.03%)	360,449k	360,966k
Parse Time	1.29s (± 0.47%)	1.27s (± 0.59%)	-0.01s (- 0.86%)	1.26s	1.29s
Bind Time	0.85s (± 0.43%)	0.85s (± 0.76%)	-0.00s (- 0.23%)	0.84s	0.86s
Check Time	4.81s (± 0.52%)	4.76s (± 0.37%)	-0.05s (- 1.02%)	4.72s	4.80s
Emit Time	3.31s (± 0.73%)	3.27s (± 0.49%)	-0.04s (- 1.21%)	3.23s	3.30s
Total Time	10.25s (± 0.50%)	10.15s (± 0.30%)	-0.10s (- 0.95%)	10.11s	10.22s
TFS - node (v9.0.0, x64)
Memory used	316,163k (± 0.01%)	316,110k (± 0.03%)	-53k (- 0.02%)	315,971k	316,367k
Parse Time	1.01s (± 0.64%)	1.01s (± 0.74%)	+0.00s (+ 0.20%)	0.99s	1.02s
Bind Time	0.61s (± 0.66%)	0.61s (± 0.77%)	+0.00s (+ 0.16%)	0.60s	0.62s
Check Time	4.36s (± 1.94%)	4.26s (± 0.90%)	-0.10s (- 2.20%)	4.21s	4.39s
Emit Time	2.98s (± 3.05%)	3.08s (± 1.65%)	+0.10s (+ 3.25%)	2.90s	3.15s
Total Time	8.96s (± 0.53%)	8.96s (± 0.44%)	+0.00s (+ 0.02%)	8.89s	9.07s
Angular - node (v9.0.0, x86)
Memory used	188,890k (± 0.05%)	188,723k (± 0.04%)	-167k (- 0.09%)	188,600k	188,845k
Parse Time	1.53s (± 0.80%)	1.53s (± 0.44%)	+0.00s (+ 0.13%)	1.52s	1.55s
Bind Time	0.87s (± 0.99%)	0.86s (± 0.40%)	-0.02s (- 1.72%)	0.85s	0.86s
Check Time	4.11s (± 0.86%)	4.08s (± 0.58%)	-0.03s (- 0.71%)	4.02s	4.13s
Emit Time	5.35s (± 0.60%)	5.33s (± 0.36%)	-0.02s (- 0.41%)	5.28s	5.37s
Total Time	11.86s (± 0.48%)	11.80s (± 0.20%)	-0.06s (- 0.53%)	11.75s	11.87s
Monaco - node (v9.0.0, x86)
Memory used	201,416k (± 0.02%)	201,362k (± 0.03%)	-54k (- 0.03%)	201,182k	201,465k
Parse Time	1.31s (± 0.75%)	1.30s (± 0.61%)	-0.01s (- 0.46%)	1.29s	1.33s
Bind Time	0.64s (± 0.70%)	0.64s (± 1.18%)	+0.01s (+ 0.94%)	0.63s	0.66s
Check Time	4.57s (± 0.49%)	4.56s (± 0.45%)	-0.01s (- 0.20%)	4.51s	4.61s
Emit Time	3.00s (± 0.78%)	3.02s (± 0.81%)	+0.03s (+ 0.87%)	2.96s	3.09s
Total Time	9.51s (± 0.32%)	9.53s (± 0.45%)	+0.02s (+ 0.18%)	9.46s	9.65s
TFS - node (v9.0.0, x86)
Memory used	177,478k (± 0.02%)	177,468k (± 0.02%)	-10k (- 0.01%)	177,367k	177,552k
Parse Time	1.02s (± 0.71%)	1.03s (± 1.48%)	+0.01s (+ 0.78%)	1.02s	1.09s
Bind Time	0.57s (± 0.97%)	0.57s (± 0.70%)	-0.00s (- 0.17%)	0.56s	0.58s
Check Time	4.02s (± 0.56%)	4.01s (± 0.56%)	-0.01s (- 0.37%)	3.96s	4.06s
Emit Time	2.70s (± 1.35%)	2.71s (± 0.79%)	+0.01s (+ 0.52%)	2.65s	2.74s
Total Time	8.32s (± 0.55%)	8.32s (± 0.57%)	+0.01s (+ 0.10%)	8.24s	8.47s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-142-generic
Architecture	x64
Available Memory	16 GB
Available Memory	1 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)
node (v9.0.0, x64)
node (v9.0.0, x86)

Scenarios

Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Angular - node (v9.0.0, x64)
Angular - node (v9.0.0, x86)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
Monaco - node (v9.0.0, x64)
Monaco - node (v9.0.0, x86)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
TFS - node (v9.0.0, x64)
TFS - node (v9.0.0, x86)

Benchmark	Name	Iterations
Current	31586	10
Baseline	master	10

* Defer union or intersection property type normalization (#31486) * Defer union or intersection property type normalization * Accept moved span * Update user baselines (#31615) * Cache widened types (#31586) * Cache widened types * Fix lint * Accept LKG

AnyhowStep · 2019-05-28T22:47:27Z

@weswigham
Do you think #31612 is related?

I think get an infinite loop. I have a repository+commit link in that issue with a repro (not minimal)

weswigham · 2019-05-29T07:14:31Z

Considering this wasn't published in a nighly until around... Now? I doubt it? Unless you mean the new nightly fixes your problem and you think this fixed it. (In which case: I unno)

Cache widened types

440cc7f

weswigham requested review from DanielRosenwasser, RyanCavanaugh, ahejlsberg and sandersn May 24, 2019 22:09

RyanCavanaugh added this to the TypeScript 3.5.0 milestone May 24, 2019

Fix lint

2a25fc7

RyanCavanaugh approved these changes May 28, 2019

View reviewed changes

weswigham merged commit cd09cbb into microsoft:master May 28, 2019

weswigham deleted the cache-widened-types branch May 28, 2019 20:13

weswigham mentioned this pull request May 28, 2019

Printing JS constructor function type causes out-of-memory error #29597

Closed

sandersn mentioned this pull request May 30, 2019

🤖 User test baselines have changed #31674

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

typescript-bot assigned weswigham Oct 21, 2025

Conversation

weswigham commented May 24, 2019

Uh oh!

weswigham commented May 24, 2019

Uh oh!

typescript-bot commented May 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weswigham commented May 24, 2019

Uh oh!

typescript-bot commented May 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weswigham commented May 24, 2019

Uh oh!

weswigham commented May 24, 2019

Uh oh!

weswigham commented May 28, 2019

Uh oh!

typescript-bot commented May 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 28, 2019

Uh oh!

AnyhowStep commented May 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weswigham commented May 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented May 24, 2019 •

edited

Loading

typescript-bot commented May 24, 2019 •

edited

Loading

typescript-bot commented May 24, 2019 •

edited

Loading

typescript-bot commented May 24, 2019 •

edited

Loading

typescript-bot commented May 28, 2019 •

edited

Loading

AnyhowStep commented May 28, 2019 •

edited

Loading

weswigham commented May 29, 2019 •

edited

Loading