Fixes for tsbuild scenarios#32788
Merged
sheetalkamat merged 6 commits intomasterfrom Aug 14, 2019
Merged
Conversation
Member
sheetalkamat
commented
Aug 9, 2019
sheetalkamat
commented
- When reporting circular reference diagnostic, instead of reporting that as a status (continuing build after that) report as error so build stops there.
- When a project is not built because it's referenced projects had error, we do not want to build the project containing reference to that project as well.
- Report error about file not in include list or file does not belong to rootDir at the file that references it. The import from root file is preferred if any otherwise first reference is used to report the error
sheetalkamat
requested review from
RyanCavanaugh,
andrewbranch,
orta,
rbuckton,
sandersn and
weswigham
…d root files at the references
sheetalkamat
force-pushed
the
tsbuildFixes
branch
from
27a5379 to
8ac4580
Compare
sandersn
requested changes
Aug 12, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
One question and a couple of suggestions.
sandersn
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.