Fix the third crash in the chrome user suite test by remembering to pass excludeThisKeyword

[weswigham]

#33687 only fixed one of two issues, as it happens.

In #33537, isBindableObjectDefinePropertyCall was changed to use a new helper to handle element accesses, but Object.defineProperty codepaths don't have handling for binding this members (and didn't handle them before), so Object.definteProperty(this._whatever, "field", { value: 12 }) would cause a crash. 🙁

It looks we we just forgot to pass in the excludeThisKeyword parameter at this callsite.

This time I've validated the that the whole chrome-devtools-frontend test no longer crashes (and, in fact, has way fewer errors)~

[andrewbranch]

Good catch, thanks 🙌

[weswigham]

@DanielRosenwasser @RyanCavanaugh

Should we chalk this crash up as a known issue in the beta? 😦

[DanielRosenwasser]

I don't think this is a beta blocker (it's already out), and I don't think it's bringing up in the release notes.

I think it is worth calling out that if this was due to a lack of nightly test coverage because everything was merged in yesterday, it's the reason we should have pushed the beta out by at least another day. Even if not, that seems like a good precedent to me.

[weswigham]

No, this was hit in the user suite run overnight - that's why it got fixed so quickly - it's just we did the first merge of most of this on Friday, fixed a pair of crashes on Monday, ran again overnight on Monday, then realized there as still a third crash in the same test, which this fixes. The failure is simply assuming fixing the isolated, minimized repro fixes the entire user test. If you're OK with shipping a beta with failing extended tests... I guess that's OK; but maybe passing/accepted user+rwc+dt tests are part of our release criteria nowadays, no? (It's not done automatically, but that's probably a good idea...)

[weswigham]

I've just enabled rolling rwc builds on release-* branches (which, um, might be awkward because baselines between release branches and master are shared, due to the internal repro shenanigans - might disable that again later), and rolling user-type runs on both master and release-* branches (and I'll remove the nightly run once that's working). Rolling DT runs will follow ❤️