More optional chaining control flow analysis#34597
Merged
ahejlsberg merged 5 commits intomasterfrom Oct 21, 2019
Merged
Conversation
rbuckton
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we expand on #33821 to reflect more effects of optional chaining in control flow analysis. Some examples:
The complete list of optional chaining constructs with control flow effects in
--strictNullChecksmode is now:o?.foo === value, where the type ofvaluedoesn't includeundefined, we removeundefinedandnullfrom the type ofoin the true branch, ando?.foo !== value, where the type ofvaluedoesn't includeundefined, we removeundefinedandnullfrom the type ofoin the false branch, ando?.foo == value, where the type ofvaluedoesn't includeundefinedornull, we removeundefinedandnullfrom the type ofoin the true branch, ando?.foo != value, where the type ofvaluedoesn't includeundefinedornull, we removeundefinedandnullfrom the type ofoin the false branch, ando?.foo === undefined,o?.foo == undefinedoro?.foo == nullwe removeundefinedandnullfrom the type ofoin the false branch, ando?.foo !== undefined,o?.foo != undefinedoro?.foo != nullwe removeundefinedandnullfrom the type ofoin the true branch, andtypeof o?.foo === "xxx"ortypeof o?.foo == "xxx", where"xxx"is not"undefined", we removeundefinedandnullfrom the type ofoin the true branch, andtypeof o?.foo !== "xxx"ortypeof o?.foo != "xxx", where"xxx"is not"undefined", we removeundefinedandnullfrom the type ofoin the false branch, andtypeof o?.foo === "undefined"ortypeof o?.foo == "undefined"we removeundefinedandnullfrom the type ofoin the false branch, andtypeof o?.foo !== "undefined"ortypeof o?.foo != "undefined"we removeundefinedandnullfrom the type ofoin the true branch, ando?.foo instanceof xxxwe removeundefinedandnullfrom the type ofoin the true branch, andcase xxxblock of aswitch (o?.foo)statement we removeundefinedandnullfrom the type ofoprovided the type ofxxxdoesn't includeundefined, andcase xxxblock of aswitch (typeof o?.foo)statement we removeundefinedandnullfrom the type ofoprovidedxxxisn't"undefined", andassertIsXXX(o?.foo), whereassertIsXXXis declared with anasserts x is XXXtype predicate and typeXXXdoesn't includeundefined, we removeundefinedandnullfrom the type ofo, andassert(xxx), whereassertis declared with anasserts xtype predicate, we reflect the false branch effects of the logical expressionxxx, including effects from optional property access chains.Fixes #34570.