Fix narrow-by-constructor logic#37698
Merged
ahejlsberg merged 2 commits intomasterfrom Mar 31, 2020
Merged
Conversation
weswigham
approved these changes
Mar 31, 2020
Member
Author
|
@RyanCavanaugh We should pull this fix into the next 3.9 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the narrow-by-constructor logic that was added in #32774:
isMatchingReferencecheck, the absence of which would cause constructor checks to erroneously narrow all references in the code path.Fixes #37660.