Skip to content

Emit 'export as namespace ts' in our bundled d.ts output #53570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakebailey wants to merge 2 commits into from
Closed

Emit 'export as namespace ts' in our bundled d.ts output #53570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
102718e
Emit 'export as namespace ts' in our bundled d.ts output
jakebailey Mar 29, 2023
87f103c
Fix missing ending newline
jakebailey Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/dtsBundler.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,11 @@ function emitAsNamespace(name, moduleSymbol) {
emitAsNamespace("ts", moduleSymbol);

write("export = ts;", WriteTarget.Both);
write("export as namespace ts;", WriteTarget.Both);

const copyrightNotice = fs.readFileSync(path.join(__dirname, "CopyrightNotice.txt"), "utf-8");
const publicContents = copyrightNotice + publicLines.join(newLine);
const internalContents = copyrightNotice + internalLines.join(newLine);
const publicContents = copyrightNotice + publicLines.join(newLine) + newLine;
const internalContents = copyrightNotice + internalLines.join(newLine) + newLine;

if (publicContents.includes("@internal")) {
console.error("Output includes untrimmed @internal nodes!");
Expand Down
3 changes: 2 additions & 1 deletion tests/baselines/reference/api/tsserverlibrary.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11064,4 +11064,5 @@ declare namespace ts {
*/
function transform<T extends Node>(source: T | T[], transformers: TransformerFactory<T>[], compilerOptions?: CompilerOptions): TransformationResult<T>;
}
export = ts;
Comment thread
jakebailey marked this conversation as resolved.
export = ts;
export as namespace ts;
3 changes: 2 additions & 1 deletion tests/baselines/reference/api/typescript.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7194,4 +7194,5 @@ declare namespace ts {
*/
function transform<T extends Node>(source: T | T[], transformers: TransformerFactory<T>[], compilerOptions?: CompilerOptions): TransformationResult<T>;
}
export = ts;
export = ts;
export as namespace ts;