Change order of deletion of identifiers during import.#242
Open
nithyaganeshng wants to merge 3 commits into
Open
Change order of deletion of identifiers during import.#242nithyaganeshng wants to merge 3 commits into
nithyaganeshng wants to merge 3 commits into
Conversation
logangirvin
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The identifiers were deleted before making sure parsing the backup file is successful.
Solution:
Change the order of deletion of identifiers to only delete after parsing the backup file is successful.
Validation:
Verified the scenario manually.
Type of change:
Risk:
Work Item links:
Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.
Documentation Links:
Please include here links to any related background documentation for this PR.