Skip to content

Use overlapped pipes in WSLC session terminate tests #40264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
benhillis wants to merge 10 commits into
base: feature/wsl-for-apps
Choose a base branch
from
+4 −4
Draft

Use overlapped pipes in WSLC session terminate tests #40264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a234ca0
Use overlapped pipes in WSLC session terminate tests
Apr 21, 2026
db9ff5a
Fix COM proxy race in session terminate tests
Apr 22, 2026
75cd4a8
Revert "Fix COM proxy race in session terminate tests"
Apr 22, 2026
bed7a3a
Fix livedump capture logic
OneBlue Apr 23, 2026
138bc58
Build a minimal version
OneBlue Apr 23, 2026
cd8e77e
Update dumptool
OneBlue Apr 23, 2026
d40713f
Restore tests
OneBlue Apr 24, 2026
133b7be
Merge remote-tracking branch 'origin/feature/wsl-for-apps' into fix/w…
OneBlue Apr 24, 2026
76cb309
Restore timeout
OneBlue Apr 24, 2026
cb7c866
Update dumptool
OneBlue Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudtest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if (${TARGET_PLATFORM} STREQUAL x64)


set(CLOUDTEST_TEST_PACKAGES "Test_Packages_2025_07_28")
set(DUMPTOOL_DROP "DumpTool_X64_2025-01-27")
set(DUMPTOOL_DROP "DumpTool_X64_2026-04-24")
elseif (${TARGET_PLATFORM} STREQUAL arm64)
set(CLOUDTEST_IMAGES)
else()
Expand Down
6 changes: 3 additions & 3 deletions test/windows/Common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ MODULE_CLEANUP(ModuleCleanup);
// The watchdog timeout is set to 3 hours.
//

#define LXSS_WATCHDOG_TIMEOUT (3 * 60 * 60 * 1000)
#define LXSS_WATCHDOG_TIMEOUT (60 * 60 * 1000)
#define LXSS_WATCHDOG_TIMEOUT_WINDOW 1000
Comment on lines 46 to 50
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says the watchdog timeout is set to 3 hours, but LXSS_WATCHDOG_TIMEOUT is now 1 hour. Please update the comment (and any related documentation) or adjust the constant so they match, since this value controls when the test watchdog will fast-fail the process.

Copilot uses AI. Check for mistakes.

//
Expand Down Expand Up @@ -662,7 +662,7 @@ void CaptureLiveDump()
{
auto PrivilegeState = wsl::windows::common::security::AcquirePrivilege(SE_DEBUG_NAME);

const std::wstring targetFile = g_dumpFolder + L"\\livedump.dmp";
const std::wstring targetFile = std::format(L"{}\\livedump.{:%FT_%H-%M-%S}.dmp", g_dumpFolder, std::chrono::system_clock::now());
LogInfo("Writing livedump in: %ls", targetFile.c_str());

wsl::windows::common::SubProcess dumpProcess{nullptr, std::format(L"{} \"{}\"", g_dumpToolPath->c_str(), targetFile.c_str()).c_str()};
Expand Down Expand Up @@ -2933,4 +2933,4 @@ void SetPathAccess(const std::filesystem::path& path, DWORD Permissions, ACCESS_

THROW_IF_WIN32_ERROR(SetNamedSecurityInfoW(
const_cast<LPWSTR>(path.c_str()), SE_FILE_OBJECT, DACL_SECURITY_INFORMATION, nullptr, nullptr, newAcl.get(), nullptr));
}
}