Skip to content

Fixed leaked container in NamedVolumesVhdSessionRecovery causing test failures in OpenContainer #40316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhillis merged 2 commits into from
Apr 25, 2026
+7 −0
Merged

Fixed leaked container in NamedVolumesVhdSessionRecovery causing test failures in OpenContainer #40316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71cbf63
Fixed leaked container in NamedVolumesVhdSessionRecovery causing test…
OneBlue Apr 24, 2026
a4c9df4
Update comment
OneBlue Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/windows/WSLCTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3670,6 +3670,7 @@ class WSLCTests

WSLC_TEST_METHOD(NamedVolumesVhdSessionRecovery)
{

WSLCDriverOption driverOpts[] = {{"SizeBytes", "1073741824"}};
ValidateNamedVolumeRecoveryContract("vhd", driverOpts, ARRAYSIZE(driverOpts));

Expand All @@ -3678,6 +3679,12 @@ class WSLCTests
const std::string volumeName = "wslc-test-named-volume-vhd";
const std::string containerName = "wslc-test-container-vhd";

// Prune containers on exit so this test doesn't leak "wslc-test-container-vhd" on exit.
auto cleanup = wil::scope_exit_log(WI_DIAGNOSTICS_INFO, [&]() {
PruneResult result;
LOG_IF_FAILED(m_defaultSession->PruneContainers(nullptr, 0, 0, &result.result));
});

WSLCVolumeOptions volumeOptions{};
volumeOptions.Name = volumeName.c_str();
volumeOptions.Driver = "vhd";
Expand Down