fix: replace bare except with except Exception in Python scripts#40319
Open
srpatcha wants to merge 4 commits intomicrosoft:masterfrom
Open
fix: replace bare except with except Exception in Python scripts#40319srpatcha wants to merge 4 commits intomicrosoft:masterfrom
srpatcha wants to merge 4 commits intomicrosoft:masterfrom
Conversation
Bare except clauses catch SystemExit and KeyboardInterrupt which prevents clean process termination.
subset() returned True when a key was missing from the outer dict, silently bypassing CI validation. Fixed to return False. Also replaced bare except clauses with 'except Exception' to avoid catching SystemExit and KeyboardInterrupt. Signed-off-by: Srikanth Patchava <spatchava@meta.com> Signed-off-by: Srikanth Patchava <srikanth.patchava@outlook.com>
Signed-off-by: Srikanth Patchava <spatchava@meta.com>
Signed-off-by: Srikanth Patchava <spatchava@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fix: replace bare except with except Exception in Python scripts
Signed-off with GPG.