fix socket channel set exit events#40924
Open
chemwolf6922 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes SocketChannel exit-event handling on Windows by actually applying the caller-specified exit events instead of effectively discarding them, so socket operations can be canceled/aborted on the intended shutdown signals.
Changes:
- Fix
SocketChannel::SetExitEventsto updatem_exitEventswith the provided events. - Return the previous exit-event list from
SetExitEventsafter updating the member.
Comment on lines
134
to
+137
| std::vector<HANDLE> SetExitEvents(std::vector<HANDLE>&& exitEvents) | ||
| { | ||
| std::vector<HANDLE> oldEvents; | ||
| std::swap(oldEvents, m_exitEvents); | ||
| return oldEvents; | ||
| std::swap(exitEvents, m_exitEvents); | ||
| return std::move(exitEvents); |
OneBlue
approved these changes
Jun 26, 2026
OneBlue
left a comment
OneBlue
left a comment
Collaborator
There was a problem hiding this comment.
Great catch, thank you !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Set the exit events as specified instead of ignoring them.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed