Use strict detection of http line ending for docker response#40932
Open
yao-msft wants to merge 4 commits into
Open
Use strict detection of http line ending for docker response#40932yao-msft wants to merge 4 commits into
yao-msft wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens Docker HTTP response header termination detection by switching from a loose \n-count heuristic to an explicit \r\n\r\n state machine, and adds a unit test to lock the behavior in.
Changes:
- Introduces
HttpHeaderEndDetector, a byte-at-a-time detector for the HTTP header terminator (\r\n\r\n). - Updates
DockerHTTPClientheader scanning to use the detector for strict end-of-header detection. - Adds a unit test validating strictness and a few edge cases around the terminator.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/windows/WSLCTests.cpp | Adds unit coverage for strict \r\n\r\n header end detection behavior. |
| src/windows/wslcsession/DockerHTTPClient.h | Replaces the old linefeed counter state with HttpHeaderEndDetector. |
| src/windows/wslcsession/DockerHTTPClient.cpp | Uses HttpHeaderEndDetector in both streaming header parsing and MSG_PEEK-based header scanning. |
| src/windows/common/HttpHeaderEndDetector.h | Adds a small state machine utility for strict \r\n\r\n detection. |
Comment on lines
+1
to
+15
| /*++ | ||
|
|
||
| Copyright (c) Microsoft. All rights reserved. | ||
|
|
||
| Module Name: | ||
|
|
||
| HttpHeaderEndDetector.h | ||
|
|
||
| Abstract: | ||
|
|
||
| This file contains a small state machine that detects the end-of-header | ||
| marker ("\r\n\r\n") in an HTTP message, one byte at a time. | ||
|
|
||
| --*/ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Follow up pr for #40849 (comment)
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
New unit test and existing tests