Add a script to validate & fix mismatches CRLF in the repo#40933
Open
OneBlue wants to merge 3 commits into
Open
Add a script to validate & fix mismatches CRLF in the repo#40933OneBlue wants to merge 3 commits into
OneBlue wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a repo validation script intended to detect (and optionally fix) non-CRLF line endings in tracked source files, and wires it into CI to prevent line-ending churn and merge conflicts.
Changes:
- Added
tools/devops/validate-line-endings.pyto detect line-ending mismatches and optionally normalize files to CRLF. - Updated the build pipeline checks stage to run a line-ending validation step (intended).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/devops/validate-line-endings.py | New Python validator to detect/fix non-CRLF line endings for selected tracked source files. |
| .pipelines/build-stage.yml | Adds a CI “line feeds” check step (currently wired to the wrong script). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds a script that blocks merging a change with mismatches CRLF in code files. clang-format does some of it, but it doesn't cover all files.
The files can be fixed via
python tools/devops/validate-line-endings.py . --fixThis will prevent needless git conflicts and copilot getting confused
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed