Skip to content

Potentially uninitialized variable in ndisbind.c #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andremueiot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Potentially uninitialized variable in ndisbind.c #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions network/ndis/ndisprot/6x/sys/debug.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ ndisprotAuditAllocMem(
)
{
PVOID pBuffer;
PNPROTD_ALLOCATION pAllocInfo;
PNPROTD_ALLOCATION pAllocInfo = NULL;

if (!ndisprotdInitDone)
{
Expand Down Expand Up @@ -88,7 +88,7 @@ ndisprotAuditAllocMem(
ndisprotdMemoryTail->Next = pAllocInfo;
}
ndisprotdMemoryTail = pAllocInfo;

ndisprotdAllocCount++;
NdisReleaseSpinLock(&(ndisprotdMemoryLock));
}
Expand Down Expand Up @@ -295,9 +295,9 @@ ndisprotFreeDbgLock(
VOID
)
{

ASSERT(ndisprotdSpinLockInitDone == 1);

ndisprotdSpinLockInitDone = 0;
NdisFreeSpinLock(&(ndisprotdLockLock));
}
Expand Down
2 changes: 1 addition & 1 deletion network/ndis/ndisprot/6x/sys/ndisbind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Return Value:
--*/
{
PNDISPROT_OPEN_CONTEXT pOpenContext;
PNDISPROT_OPEN_CONTEXT pOpenContext = NULL;
NDIS_STATUS Status;

UNREFERENCED_PARAMETER(ProtocolDriverContext);
Expand Down
1 change: 1 addition & 0 deletions network/ndis/ndisprot/6x/test/prottest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ GetSrcMac(
BytesReturned));

#pragma warning(suppress:6202) // buffer overrun warning - enough space allocated in QueryBuffer
// codeql[cpp/buffer-overflow]
memcpy(pSrcMacAddr, pQueryOid->Data, MAC_ADDR_LEN);
}
else
Expand Down
2 changes: 1 addition & 1 deletion network/ndis/ndisprot_kmdf/60/debug.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ ndisprotAuditAllocMem(
)
{
PVOID pBuffer;
PNPROTD_ALLOCATION pAllocInfo;
PNPROTD_ALLOCATION pAllocInfo = NULL;

if (!ndisprotdInitDone)
{
Expand Down
13 changes: 8 additions & 5 deletions network/ndis/ndisprot_kmdf/60/ndisbind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,17 @@ Routine Description:

Arguments:

ProtocolDriverContext - handle to the protocol driver context
BindContext - handle to the bind context provided by NDIS
BindParameters - parameters describing the adapter to which we are binding

Return Value:

None
NDIS_STATUS_SUCCESS if successful, failure code otherwise.

--*/
{
PNDISPROT_OPEN_CONTEXT pOpenContext;
PNDISPROT_OPEN_CONTEXT pOpenContext = NULL;
NDIS_STATUS Status;
WDF_IO_QUEUE_CONFIG queueConfig;
NTSTATUS ntStatus;
Expand Down Expand Up @@ -1334,9 +1337,9 @@ Return Value:
while (FALSE);

DEBUGP(DL_LOUD, ("ValidateOpenAndDoReq: Open %p/%x, OID %x, Status %x\n",
pOpenContext,
pOpenContext == NULL ? 0 : pOpenContext->Flags,
Oid,
pOpenContext,
pOpenContext == NULL ? 0 : pOpenContext->Flags,
Oid,
Status));

return (Status);
Expand Down
Loading