MSIX: Always include PackageIntegrity/Content[Enforcement=on]#6613
Open
DrusTheAxe wants to merge 1 commit into
Open
MSIX: Always include PackageIntegrity/Content[Enforcement=on]#6613DrusTheAxe wants to merge 1 commit into
DrusTheAxe wants to merge 1 commit into
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows App SDK VS New Project templates’ MSIX appxmanifest files to always opt-in to MSIX package integrity content enforcement by adding uap10:PackageIntegrity with uap10:Content Enforcement="on".
Changes:
- Added the
uap10XML namespace to template appxmanifest files. - Added
uap10toIgnorableNamespacesto support downlevel parsing behavior. - Added
uap10:PackageIntegrity/uap10:Content Enforcement="on"to all project-template MSIX manifests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| dev/Templates/Source/ProjectTemplates/Desktop/CSharp/UnitTestApp/Package-managed.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CSharp/TabViewApp/Package-managed.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CSharp/SingleProjectPackagedApp/Package-managed.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/WapProj/Package-managed.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CSharp/NavigationApp/Package-managed.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CSharp/MvvmApp/Package-managed.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/UnitTestApp/Package-native.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/SingleProjectPackagedApp/Package-native.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
| dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/WapProj/Package-managed.appxmanifest | Adds uap10 namespace + PackageIntegrity opt-in (currently inserted under <Properties>). |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
Comment on lines
+23
to
+25
| <uap10:PackageIntegrity> | ||
| <uap10:Content Enforcement="on"/> | ||
| </uap10:PackageIntegrity> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All appxmanifest.xml should include
uap10:Content - Windows UWP applications | Microsoft Learn
Store-signed packages received a degree of additional protection since Win8 -- pkgdir lockdown (TrustLevel ACE, etc), some pkgdir / blockmap verifications at activation, etc.
This was later (20H1 aka 10.0.19041.0) extended to other signed packages, if they opt-in via
<uap10:PackageIntegrity>.This manifest option is ignored if not relevant (e.g. the package isn't signed).
NOTE:
Enforcementoptions areon,off, anddefault(ie Windows decides, currently equivalent to off). While Windows could change the default behavior to on, that wouldn't help for existing downlevel Windows systems. So always specifying it in the manifest is the right answer, until if/when Windows treatsdefaultequivalent toon, and is ubiquitous across the ecosystem (IOW, a loooong way into the future, at best).NOTE: This does for WinAppSDK's VS/File/NewProject... templates as MSIX: Always include PackageIntegrity/Content[Enforcement=on] does for winappcli