Open
Conversation
Contributor
mgurlitz
commented
Jan 16, 2020
mgurlitz
commented
- Converted main library to support .NET Framework 4.6 + Standard 2.1
- Converted tests/samples to run with .NET Core 3.1
- Removed UWP support, since Standard 2.0 works with it and 2.1 is "TBD"
- Replaced UWP-only credentials library with an alternative from NuGet
- Replaced partial classes used for testing with internal mockable interfaces
- Fixed Xbox deployment test bug related to mock setup
- Converted main library to support .NET Framework 4.6 + Standard 2.1 - Converted tests/samples to .NET Core 3.1 - Removed UWP support - Replaced UWP credentials library w/ NuGet alternative - Replaced partial classes used for testing with internal interfaces - Fixed Xbox deployment test mock bug
WilliamsJason
previously approved these changes
Jan 16, 2020
Contributor
WilliamsJason
left a comment
WilliamsJason
left a comment
There was a problem hiding this comment.
Obviously lots of renames and deletes here so I haven't looked exhaustively at this. I trust the automated tests still run and pass?
If you don't have an Xbox device to test this on, I can sync and test some basic functionality on Xbox later, after we complete the PR.
Contributor
Author
|
Yeah, the unit tests all pass, and I verified the sample programs work with both a PC and Xbox devkit, thank you! The only thing I haven't tried running is the MockDataGenerator. |
david-c-kline
dismissed
WilliamsJason’s stale review
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.