Open
Conversation
brwai
force-pushed
the
brwai/add-custom-user-config
branch
from
ab7f7b8 to
d86362e
Compare
brwai
force-pushed
the
brwai/add-custom-user-config
branch
from
d86362e to
07325b4
Compare
dannyvv
reviewed
Oct 7, 2024
| process.env["HOME"] || process.env["USERPROFILE"] || homedir() || ""; | ||
| this.userFilePath = join(userHome, workspaceFileName); | ||
| if (userConfigFile && path.basename(userConfigFile) === this.workspaceFileName) { | ||
| this.userFilePath = userConfigFile; |
Member
There was a problem hiding this comment.
What is the expected behavior if the user passes --userConfigFile and the user when the passed in file does not match the workspace filename (i.e. missing the dot for npmrc file: --userConfigFile npmrc) then userFilePath will be undefined.
Should this be an error or should we chang the else block to check if userFilePath has not been set yet?
Author
There was a problem hiding this comment.
If the filename from provided userConfigFile does not match workspace filename, then the if condition is false then the else condition will be triggered therefore setting the default userFilePath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users who don't have projects under their home directory, the default location of user config file will not work. Adding a new argument option to allow custom user config file path.
Also fixes a problem where user .yarnrc.yml config file does not automatically get created if it doesn't exist.