Skip to content

docs: OWASP upstream AGT reference implementation supporting material#844

Closed
jackbatzner wants to merge 3 commits intomicrosoft:mainfrom
jackbatzner:jb/owasp-upstream-reference-submission
Closed

docs: OWASP upstream AGT reference implementation supporting material#844
jackbatzner wants to merge 3 commits intomicrosoft:mainfrom
jackbatzner:jb/owasp-upstream-reference-submission

Conversation

@jackbatzner
Copy link
Copy Markdown
Contributor

Description

Adds an external-facing supporting-material document formatted for submission to the OWASP Agentic AI Top 10 project. This lives in AGT for now and can be adapted as a PR to the OWASP repo.

What this delivers

Imran's Discussion #814 calls for "contribute back implementation patterns as reference architectures." This document does exactly that:

  • Uses AAI risk IDs (the OWASP project's canonical IDs, not our internal ASI IDs)
  • Describes generic, reusable mitigation patterns that any agent governance toolkit could implement
  • Cites AGT source files as concrete evidence, not as the only way to implement the pattern
  • Includes 2 Mermaid architecture diagrams (defense pipeline + deployment topology)
  • Honest about partial coverage (AAI014, AAI009, AAI012 explicitly called out)
  • Identifies 5 lessons learned including standardization gaps

Review notes

  • All 19 evidence links verified against actual repo files
  • All 10 AAI IDs match the upstream OWASP project exactly
  • ~1,200 words — concise enough for OWASP reviewers
  • Passed multi-perspective review (maintainer, code reviewer, OWASP standards reviewer)

Type of Change

  • Documentation update

Package(s) Affected

  • docs / root

Checklist

  • My code follows the project style guidelines (ruff check)
  • I have added tests that prove my fix/feature works
  • All new and existing tests pass (pytest)
  • I have updated documentation as needed
  • I have signed the Microsoft CLA

Related Issues

Relates to Discussion #814 (Agentic Standards Landscape - contribute back reference architectures)

@github-actions github-actions bot added documentation Improvements or additions to documentation size/M Medium PR (< 200 lines) labels Apr 6, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Agent: code-reviewer

Review Feedback for Pull Request: OWASP Upstream AGT Reference Implementation Supporting Material

General Observations

The addition of the supporting material document for the OWASP Agentic AI Top 10 project is a valuable contribution. It effectively outlines reusable implementation patterns and provides concrete evidence from the Microsoft Agent Governance Toolkit (AGT). The structure is clear, and the use of diagrams enhances understanding.

Actionable Feedback

  1. Documentation Completeness:

    • The document is well-structured and provides a comprehensive overview of the implementation patterns. However, consider adding a brief introduction to each section that explains the significance of the corresponding AAI risk ID. This will help readers unfamiliar with the OWASP framework understand the context better.
    • 💡 SUGGESTION: Include a summary or conclusion section that reiterates the importance of the patterns discussed and how they contribute to the overall security posture of agent systems.
  2. Clarity on Partial Coverage:

    • You mention partial coverage for some AAI risk IDs (e.g., AAI014, AAI012). It would be beneficial to clarify what "partial coverage" means in this context. Are there specific areas where the AGT falls short, or are there additional measures that should be considered?
    • 💡 SUGGESTION: Provide specific recommendations or references to additional resources for addressing these gaps.
  3. References and Evidence Links:

    • The evidence links are well-documented, but consider ensuring that they are consistently formatted. For instance, some links have additional context while others do not.
    • 💡 SUGGESTION: Standardize the format of the evidence links to maintain consistency and improve readability.
  4. Mermaid Diagrams:

    • The Mermaid diagrams are a great addition, but ensure that they are rendered correctly in the documentation. Verify that the rendering works in the GitHub markdown environment.
    • 💡 SUGGESTION: Consider adding captions or brief descriptions for each diagram to explain what they represent and how they relate to the text.
  5. Testing and Validation:

    • While this is a documentation update, it is important to ensure that the content is accurate and reflects the current state of the AGT. Consider implementing a review process for future documentation updates to ensure ongoing accuracy.
    • 💡 SUGGESTION: Establish a regular review cycle for documentation to keep it aligned with code changes and evolving security practices.
  6. OWASP Compliance:

    • Ensure that the document aligns with OWASP's guidelines for contributions. This includes proper attribution and adherence to their formatting and content standards.
    • 💡 SUGGESTION: Review OWASP's contribution guidelines to ensure compliance before submitting to the OWASP repository.

Conclusion

Overall, this pull request is a strong contribution to the AGT documentation and the OWASP Agentic AI Top 10 project. By addressing the suggestions above, you can enhance the clarity and effectiveness of the document, ensuring it serves as a valuable resource for the community. Thank you for your efforts in improving the security landscape for agent systems!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

🤖 AI Agent: security-scanner — Security Review of Pull Request

Security Review of Pull Request

This pull request primarily adds documentation to the repository, specifically a supporting-material document for submission to the OWASP Agentic AI Top 10 project. While the changes are focused on documentation, they reference implementation patterns and specific files in the repository. As such, the review will focus on whether the documentation introduces or exposes any security risks, such as incorrect guidance or misrepresentation of security controls.


Findings

1. Prompt Injection Defense Bypass

  • Risk Level: 🔵 LOW
  • Analysis: The document references the "prompt injection detector" and "MCP proxy sanitizer" as mechanisms for mitigating AAI003 (Agent Goal and Instruction Manipulation). However, it does not explicitly describe the limitations of these mechanisms, such as the potential for bypass via novel encoding techniques or multi-turn attacks. While this is a documentation issue, it could lead to overconfidence in the effectiveness of these defenses.
  • Recommendation: Add a note in the documentation emphasizing that prompt injection defenses should be continuously updated to address emerging attack vectors and that layered defenses are critical.

2. Policy Engine Circumvention

  • Risk Level: 🔵 LOW
  • Analysis: The document describes the policy engine as a central enforcement point for authorization and trust. While this is accurate, the documentation does not explicitly warn about the risks of misconfigured or overly permissive policies, which could allow circumvention.
  • Recommendation: Update the documentation to include a warning about the importance of rigorous policy configuration and testing to prevent circumvention.

3. Trust Chain Weaknesses

  • Risk Level: 🔵 LOW
  • Analysis: The document mentions the use of identity and trust gates but does not detail how trust is established or verified (e.g., SPIFFE/SVID validation, certificate pinning). This omission could lead to misunderstandings about the robustness of the trust model.
  • Recommendation: Include a brief explanation of how trust is established and validated in AGT, and reference any relevant standards or best practices (e.g., SPIFFE, X.509).

4. Credential Exposure

  • Risk Level: 🔵 LOW
  • Analysis: There is no indication that the documentation introduces any risk of credential exposure. The referenced files and patterns do not appear to log or expose sensitive information.
  • Recommendation: No changes needed.

5. Sandbox Escape

  • Risk Level: 🔵 LOW
  • Analysis: The document highlights the use of execution boundaries and kernel/user separation to mitigate AAI002 (Agent Critical Systems Interaction). However, it does not explicitly address the risk of sandbox escape or the importance of regular updates to the underlying sandboxing mechanisms.
  • Recommendation: Add a note about the importance of keeping sandboxing mechanisms up to date to prevent potential escape vulnerabilities.

6. Deserialization Attacks

  • Risk Level: 🔵 LOW
  • Analysis: The document does not reference any deserialization mechanisms or patterns. There is no indication that this PR introduces or exposes risks related to unsafe deserialization.
  • Recommendation: No changes needed.

7. Race Conditions

  • Risk Level: 🔵 LOW
  • Analysis: The document does not discuss concurrency or race conditions in policy checks or trust evaluations. While this is not directly relevant to the documentation, it is worth noting that race conditions in these areas could lead to security vulnerabilities.
  • Recommendation: Consider adding a note about the importance of designing policy engines and trust gates to handle concurrent requests safely.

8. Supply Chain Risks

  • Risk Level: 🔵 LOW
  • Analysis: The document mentions the use of SupplyChainGuard for mitigating AAI009 (Agent Supply Chain and Dependency Attacks) and highlights the importance of CI-based enforcement. This is a strong point, but the document could further emphasize the importance of monitoring for dependency updates and vulnerabilities over time.
  • Recommendation: Add a note about the need for ongoing monitoring of dependencies for vulnerabilities and updates, even after initial deployment.

Overall Assessment

This pull request does not introduce any direct security vulnerabilities, as it is focused on documentation. However, there are opportunities to improve the clarity and completeness of the documentation to ensure that users of the toolkit are fully aware of potential risks and best practices.

Summary of Recommendations

  1. Emphasize the need for continuous updates to prompt injection defenses.
  2. Warn about the risks of misconfigured or overly permissive policies in the policy engine.
  3. Provide more detail on how trust is established and validated (e.g., SPIFFE/SVID, certificate pinning).
  4. Highlight the importance of keeping sandboxing mechanisms up to date to prevent escape vulnerabilities.
  5. Consider adding notes on concurrency safety in policy engines and trust gates.
  6. Stress the importance of ongoing monitoring for dependency vulnerabilities and updates.

No critical or high-severity issues were identified in this review. The changes are safe to merge with the suggested improvements to the documentation.

@jackbatzner
Copy link
Copy Markdown
Contributor Author

Upstream OWASP submission:

The adapted doc has been submitted as a draft supporting-material PR to the OWASP Agentic AI Top 10 project. Once editors engage and this PR merges, we can mark the draft as ready for review.

@jackbatzner
Copy link
Copy Markdown
Contributor Author

Update: Corrected upstream OWASP submission

The previous submission to precize/Agentic-AI-Top10-Vulnerability was the wrong repo (community project, not official OWASP). Closed that and resubmitted to the official repo:

Copy link
Copy Markdown
Member

@imran-siddique imran-siddique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good supporting material. spell-check CI is failing — please fix the flagged spelling issues, then ready to merge.

@jackbatzner jackbatzner force-pushed the jb/owasp-upstream-reference-submission branch from bd8b520 to 68e890d Compare April 6, 2026 20:14
@github-actions github-actions bot added the size/L Large PR (< 500 lines) label Apr 6, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Agent: code-reviewer

Review Summary

The pull request introduces a new documentation file that serves as supporting material for the OWASP Agentic AI Top 10 project. It outlines reusable implementation patterns relevant to agent governance, referencing specific components of the Microsoft Agent Governance Toolkit (AGT). The document is well-structured and provides valuable insights into the security measures implemented within AGT.

Actionable Feedback

  1. Documentation Clarity:

    • The document is comprehensive and well-organized. However, consider adding a brief summary at the beginning that outlines the purpose of the document and its intended audience. This will help readers quickly understand the context and importance of the content.
  2. Mermaid Diagrams:

    • The use of Mermaid diagrams is effective for visual representation. Ensure that these diagrams are rendered correctly in the documentation viewer used by OWASP. It may be beneficial to include a note on how to view these diagrams if they do not render automatically.
  3. References and Evidence Links:

    • The evidence links are well-cited, but consider adding a brief description next to each link to clarify what the reader can expect to find there. This will enhance the usability of the document and guide readers to relevant sections more efficiently.
  4. Lessons Learned Section:

    • The lessons learned section is insightful. To enhance its impact, consider formatting it as a bulleted list or using headings for each lesson. This will make it easier for readers to scan and absorb the key takeaways.
  5. Testing and Validation:

    • While this is a documentation update, it is important to ensure that the content is accurate and reflects the current state of the AGT. Consider implementing a review process for future documentation updates to ensure ongoing accuracy and relevance.

Security and Compliance Considerations

  • OWASP Compliance:
    • The document aligns well with OWASP's goals by addressing the Agentic AI Top 10 vulnerabilities. Ensure that any future updates to the OWASP project are reflected in this document to maintain compliance and relevance.

Conclusion

Overall, this pull request is a valuable contribution to the AGT documentation and the broader OWASP community. The suggestions provided aim to enhance clarity, usability, and ongoing relevance. No critical security issues or breaking changes were identified in this documentation update.

Final Note

Please ensure that the documentation is reviewed periodically to keep it aligned with the evolving security landscape and OWASP standards.

jackbatzner and others added 3 commits April 8, 2026 08:31
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jackbatzner jackbatzner force-pushed the jb/owasp-upstream-reference-submission branch from 68e890d to 9b12e5d Compare April 8, 2026 13:31
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Agent: code-reviewer

Review Summary

This PR introduces a well-structured and comprehensive supporting document for submission to the OWASP Agentic AI Top 10 project. The document provides reusable mitigation patterns, maps them to OWASP AAI risk IDs, and cites concrete evidence from the AGT repository. It also includes architectural diagrams and lessons learned, which enhance the document's clarity and utility.

The PR is primarily documentation-focused, so it does not directly impact the codebase or runtime behavior. However, the document references specific implementation files, which were verified to exist in the repository. Below are the detailed findings and recommendations.


🔴 CRITICAL

No critical security issues were identified in this PR. The document correctly maps AGT's implementation patterns to OWASP AAI risks and provides accurate references to the relevant code files.


🟡 WARNING

  1. Partial Coverage Acknowledgment
    The document explicitly mentions partial coverage for AAI014 (Agent Alignment Faking Vulnerability) and AAI012 (Agent Checker Out of the Loop Vulnerability). While this is a documentation PR, these gaps in coverage could lead to potential security risks if not addressed in the future.

    • Action: Consider creating follow-up issues to track the implementation of full coverage for these risks.
  2. Backward Compatibility
    The document introduces no breaking changes to the public API. However, the referenced files and patterns are now part of the public-facing documentation. Any future changes to these files could inadvertently break the alignment with the OWASP submission.

    • Action: Add a note to the repository's contribution guidelines to ensure that changes to the referenced files are reviewed for consistency with the OWASP documentation.

💡 SUGGESTIONS

  1. Mermaid Diagram Accessibility
    The Mermaid diagrams are helpful but may not render correctly in all Markdown viewers or static documentation generators.

    • Suggestion: Include static image versions of the diagrams as a fallback for environments that do not support Mermaid rendering.
  2. Evidence Link Validation
    While all evidence links were verified to exist, there is no automated mechanism to ensure their validity over time.

    • Suggestion: Add a CI check to validate that all evidence links in the documentation point to existing files in the repository.
  3. Standardization Gaps
    The lessons learned section highlights the need for standards in areas like portable trust assertions and tamper-evident audit formats.

    • Suggestion: Consider collaborating with the OWASP Agentic AI Top 10 project or other standardization bodies to address these gaps.
  4. Document Maintenance
    This document is intended for submission to an external project (OWASP). Over time, the AGT implementation may evolve, potentially diverging from the patterns described in the document.

    • Suggestion: Assign ownership of this document to a specific team or individual to ensure it remains up-to-date.
  5. Typographical Consistency
    The document uses both "AAI" and "Agentic AI" to refer to the OWASP project.

    • Suggestion: Standardize the terminology throughout the document for clarity.

Final Assessment

This PR is well-prepared and aligns with the project's goals of contributing to the OWASP Agentic AI Top 10 initiative. While there are no critical issues, addressing the warnings and suggestions will ensure the document remains accurate, accessible, and maintainable over time.

  • Approval Status: ✅ Approved with minor suggestions for improvement.

imran-siddique added a commit to imran-siddique/agent-governance-toolkit that referenced this pull request Apr 9, 2026
- Migrate copilot-governance from legacy AT identifiers to OWASP ASI 2026
- Add backward-compatible AT→ASI lookup for existing integrations
- Add comprehensive OWASP Agentic Top 10 reference architecture doc
- Add standalone agent-mcp-governance Python package

Supersedes: microsoft#839, microsoft#843, microsoft#844, microsoft#829

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@imran-siddique
Copy link
Copy Markdown
Member

Closing in favor of #910 which merges this supporting material with #843's architecture mapping into one comprehensive reference document.

Thank you for the evidence-based approach with code-line references — that methodology carries forward in the combined doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/L Large PR (< 500 lines) size/M Medium PR (< 200 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants