Fix Azure Redis generated Bicep and customize infrastructure api#1264
Open
Waleed-KH wants to merge 2 commits into
Open
Fix Azure Redis generated Bicep and customize infrastructure api#1264Waleed-KH wants to merge 2 commits into
Waleed-KH wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Azure Cache for Redis (hosted) integration docs to use Azure Cache for Redis Enterprise (cluster + database) resources and corresponding infrastructure customization examples.
Changes:
- Switches the Bicep sample from
Microsoft.Cache/redistoMicrosoft.Cache/redisEnterpriseand adds adatabaseschild resource. - Updates the access policy assignment example to target the Redis Enterprise database scope.
- Updates the .NET and JS infrastructure customization snippets to use Redis Enterprise types/SKU naming.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+342
to
346
| redisCache.Sku = new RedisEnterpriseSku | ||
| { | ||
| Name = RedisSkuName.Standard, | ||
| Family = RedisSkuFamily.C, | ||
| Name = RedisEnterpriseSkuName.BalancedB1, | ||
| Capacity = 1, | ||
| }; |
| } | ||
|
|
||
| output connectionString string = '${cache.properties.hostName},ssl=true' | ||
| output connectionString string = '${cache.properties.hostName}:10000,ssl=true' |
Comment on lines
+312
to
321
| resource cache_default_contributor 'Microsoft.Cache/redisEnterprise/databases/accessPolicyAssignments@2025-07-01' = { | ||
| name: guid(cache_default.id, principalId, 'default') | ||
| properties: { | ||
| accessPolicyName: 'Data Contributor' | ||
| objectId: principalId | ||
| objectIdAlias: principalName | ||
| accessPolicyName: 'default' | ||
| user: { | ||
| objectId: principalId | ||
| } | ||
| } | ||
| parent: cache | ||
| parent: cache_default | ||
| } |
| output hostName string = cache.properties.hostName | ||
| ``` | ||
|
|
||
| In addition, role assignments are created for the Azure resource in a separate module: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.