Skip to content

Remove checked-in .modules folders and add to .gitignore#15549

Merged
adamint merged 1 commit intomicrosoft:mainfrom
adamint:dev/adamint/remove-modules-folders
Mar 24, 2026
Merged

Remove checked-in .modules folders and add to .gitignore#15549
adamint merged 1 commit intomicrosoft:mainfrom
adamint:dev/adamint/remove-modules-folders

Conversation

@adamint
Copy link
Member

@adamint adamint commented Mar 24, 2026

Description

Remove all checked-in .modules generated folders (204 files across 51 directories under playground/) and add .modules/ to the root .gitignore so they are not tracked in the future.

These folders contain auto-generated TypeScript Aspire module files (.codegen-hash, aspire.ts, base.ts, transport.ts) that should not be committed to source control.

With the changes in #15546, there should be no added friction if opening in vs code

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15549

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15549"

@adamint adamint requested a review from sebastienros March 24, 2026 21:26
@adamint adamint self-assigned this Mar 24, 2026
@adamint adamint marked this pull request as ready for review March 24, 2026 21:26
Copilot AI review requested due to automatic review settings March 24, 2026 21:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes checked-in generated TypeScript Aspire .modules artifacts from the playground and intends to prevent them from being committed again.

Changes:

  • Deletes checked-in .modules generated sources (base.ts, transport.ts) and .codegen-hash files under playground/.
  • Reduces repository noise by removing auto-generated module output from source control.

Reviewed changes

Copilot reviewed 49 out of 205 changed files in this pull request and generated no comments.

Show a summary per file
File Description
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Kusto/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Kusto/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/transport.ts Removes generated transport module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/transport.ts Removes generated transport module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/transport.ts Removes generated transport module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/transport.ts Removes generated transport module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppService/ValidationAppHost/.modules/transport.ts Removes generated transport module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppService/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppService/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/transport.ts Removes generated transport module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/base.ts Removes generated base module file from repo
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/TypeScriptApps/RpsArena/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/base.ts Removes generated base module file from repo
playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
playground/TypeScriptAppHost/.modules/.codegen-hash Removes generated codegen hash file from repo
Comments suppressed due to low confidence (1)

playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/base.ts:1

  • The PR title/description mention adding .modules/ to the root .gitignore, but that change is not included in the provided diffs. If it’s missing from the actual commit, please add the ignore rule to prevent these generated folders from being reintroduced.

@adamint adamint enabled auto-merge (squash) March 24, 2026 21:50
@github-actions
Copy link
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

@adamint adamint merged commit ec7f74a into microsoft:main Mar 24, 2026
494 of 497 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants