Remove checked-in .modules folders and add to .gitignore#15549
Remove checked-in .modules folders and add to .gitignore#15549adamint merged 1 commit intomicrosoft:mainfrom
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15549Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15549" |
There was a problem hiding this comment.
Pull request overview
Removes checked-in generated TypeScript Aspire .modules artifacts from the playground and intends to prevent them from being committed again.
Changes:
- Deletes checked-in
.modulesgenerated sources (base.ts,transport.ts) and.codegen-hashfiles underplayground/. - Reduces repository noise by removing auto-generated module output from source control.
Reviewed changes
Copilot reviewed 49 out of 205 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Kusto/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Kusto/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/transport.ts | Removes generated transport module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/transport.ts | Removes generated transport module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/transport.ts | Removes generated transport module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/transport.ts | Removes generated transport module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppService/ValidationAppHost/.modules/transport.ts | Removes generated transport module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppService/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppService/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/transport.ts | Removes generated transport module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/TypeScriptApps/RpsArena/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/base.ts | Removes generated base module file from repo |
| playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
| playground/TypeScriptAppHost/.modules/.codegen-hash | Removes generated codegen hash file from repo |
Comments suppressed due to low confidence (1)
playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/.modules/base.ts:1
- The PR title/description mention adding
.modules/to the root.gitignore, but that change is not included in the provided diffs. If it’s missing from the actual commit, please add the ignore rule to prevent these generated folders from being reintroduced.
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Description
Remove all checked-in
.modulesgenerated folders (204 files across 51 directories underplayground/) and add.modules/to the root.gitignoreso they are not tracked in the future.These folders contain auto-generated TypeScript Aspire module files (
.codegen-hash,aspire.ts,base.ts,transport.ts) that should not be committed to source control.With the changes in #15546, there should be no added friction if opening in vs code
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: