Fix Banner_NotDisplayedWithNoLogoFlag E2E test (#14307)#15570
Open
Fix Banner_NotDisplayedWithNoLogoFlag E2E test (#14307)#15570
Conversation
- Replace hardcoded 'Commands:' check with HelpGroupStrings.HelpHint resource (help output now uses grouped headings instead of a single 'Commands:' heading) - Replace hardcoded 'Welcome to the' with RootCommandStrings.BannerWelcomeText - Add RootCommandStrings and HelpGroupStrings resource references to csproj - Remove [ActiveIssue] attribute to re-enable the test
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15570Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15570" |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Banner_NotDisplayedWithNoLogoFlag Aspire CLI E2E test by updating its help-output completion signal to align with the refactored grouped help headings, and by switching banner text checks to resource-backed strings for stability.
Changes:
- Update banner text assertions to use
RootCommandStrings.BannerWelcomeTextinstead of hardcoded"Welcome to the". - Change the
--helpcompletion wait condition from a"Commands:"sentinel toHelpGroupStrings.HelpHint(end-of-help hint text). - Add linked resource designer/resx entries for
HelpGroupStringsandRootCommandStringsto the E2E test project.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Aspire.Cli.EndToEnd.Tests/BannerTests.cs | Updates wait/assert logic to use resource strings and a more reliable end-of-help marker. |
| tests/Aspire.Cli.EndToEnd.Tests/Aspire.Cli.EndToEnd.Tests.csproj | Adds required linked resource designer/resx files so tests can use RootCommandStrings and HelpGroupStrings. |
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 2 jobs were identified as retry-safe transient failures in the CI run attempt.
|
Contributor
|
🎬 CLI E2E Test Recordings — 50 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23524951068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the
Banner_NotDisplayedWithNoLogoFlagE2E test and re-enable it by removing the[ActiveIssue]attribute.Root cause: The test was checking for
"Commands:"in the help output to confirm the command completed, but help output was refactored to use grouped headings ("App commands:","Resource management:", etc.) instead of a single"Commands:"heading. This meant theWaitUntilAsyncwould never find a match and timed out after 30 seconds.Fix:
"Commands:"check withHelpGroupStrings.HelpHint— the help hint text that appears at the very end of help output, ensuring the full output has rendered before asserting"Welcome to the"strings withRootCommandStrings.BannerWelcomeTextresource referencesRootCommandStringsandHelpGroupStringsresource references to the E2E test csproj (following existing pattern for other resource files)[ActiveIssue]to re-enable the testFixes #14307
Checklist