fix(autogen-ext): restrict unpickling of task-centric memory files#7761
Open
White-Mouse wants to merge 1 commit into
Open
fix(autogen-ext): restrict unpickling of task-centric memory files#7761White-Mouse wants to merge 1 commit into
White-Mouse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The experimental task-centric memory feature persists local state to disk (e.g. uid_memo_dict.pkl / uid_text_dict.pkl). On startup, the current implementation uses pickle.load(...) to deserialize those files.
This PR switches those loads to a small restricted unpickler allowlist (builtins containers/primitives + Memo for the memo dict) and adds regression coverage that unsafe globals are blocked during load.
Why
pickle is not safe for untrusted inputs. These persisted files are easy to copy between projects or restore from shared storage; failing closed here reduces the risk of arbitrary code execution if a .pkl file is replaced or tampered with.
Verification