Fix Anthropic requests ending with assistant messages#7781
Open
jdoughty04 wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Anthropic rejects requests when the final conversation turn is an assistant message. The current
_rstrip_last_assistant_messagehelper only strips trailing whitespace from that message, so a non-empty trailing assistant response still gets sent to Anthropic unchanged.This updates the helper to drop trailing assistant messages before request conversion. It also avoids mutating the caller's original message history and adds coverage for both consecutive trailing assistant messages and assistant messages that appear earlier in the conversation.
Related issue number
Closes #7768
Checks
Local validation:
uv run --extra anthropic pytest tests/models/test_anthropic_model_client.py -quv run ruff format --check src/autogen_ext/models/anthropic/_anthropic_client.py tests/models/test_anthropic_model_client.pyuv run ruff check src/autogen_ext/models/anthropic/_anthropic_client.py tests/models/test_anthropic_model_client.pyuv run pyright src/autogen_ext/models/anthropic/_anthropic_client.py tests/models/test_anthropic_model_client.pyuv run python -m py_compile src/autogen_ext/models/anthropic/_anthropic_client.pygit diff --check