fix(cloud-init): update cloud-init to correctly support azl4#16938
Open
ddstreet wants to merge 6 commits intomicrosoft:tomls/base/mainfrom
Open
fix(cloud-init): update cloud-init to correctly support azl4#16938ddstreet wants to merge 6 commits intomicrosoft:tomls/base/mainfrom
ddstreet wants to merge 6 commits intomicrosoft:tomls/base/mainfrom
Conversation
ddstreet
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the cloud-init component packaging for Azure Linux 4 by ensuring the rendered templates/configs are generated with an azurelinux variant and by patching upstream templates to recognize that variant.
Changes:
- Add a patch to include
azurelinuxin cloud-init’s systemd unit/generator templates. - Add a patch to adjust
cloud.cfgtemplate behavior forazurelinux(including default user handling) and update the related unit test. - Update
cloud-init.comp.tomloverlays to apply the new patches and to replace the spec’srender-template --variant ...invocation with--variant azurelinux.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| base/comps/cloud-init/cloud-init.comp.toml | Adds new Patch/file overlays and changes the spec search/replace to force --variant azurelinux. |
| base/comps/cloud-init/add-azurelinux-to-systemd-templates.patch | Extends systemd template conditionals to treat azurelinux like Fedora/RHEL-family variants where appropriate. |
| base/comps/cloud-init/update-cloud-cfg.patch | Adjusts cloud.cfg template logic for azurelinux and updates an upstream unit test expectation. |
Contributor
Author
|
converting to draft temporarily, so i can get real patches set up in a branch on a forked cloud-init repo. |
ddstreet
force-pushed
the
cloud-init-cfg
branch
22 times, most recently
from
c199738 to
e7bc499
Compare
ddstreet
force-pushed
the
cloud-init-cfg
branch
7 times, most recently
from
0c18f7f to
4f58c0f
Compare
…nux.patch The description describes the cpe parsing as invalid, but it's actually just a newer cpe format.
ddstreet
force-pushed
the
cloud-init-cfg
branch
8 times, most recently
from
11bfb82 to
653352f
Compare
ddstreet
force-pushed
the
cloud-init-cfg
branch
2 times, most recently
from
588965c to
4024b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the spec file to pass the variant as 'azurelinux', as well as applying patches from upstream PR canonical/cloud-init#6874