Skip to content

[AutoPR- Security] Patch cert-manager for CVE-2026-56852 [HIGH] - #18151

Merged
jslobodzian merged 2 commits into
microsoft:fasttrack/3.0from
azurelinux-security:azure-autosec/cert-manager/3.0/1168552
Jul 28, 2026
Merged

[AutoPR- Security] Patch cert-manager for CVE-2026-56852 [HIGH]#18151
jslobodzian merged 2 commits into
microsoft:fasttrack/3.0from
azurelinux-security:azure-autosec/cert-manager/3.0/1168552

Conversation

@azurelinux-security

@azurelinux-security azurelinux-security commented Jul 27, 2026

Copy link
Copy Markdown

Auto Patch cert-manager for CVE-2026-56852.

Autosec pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1168552&view=results

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

YES/NO

Associated issues
  • N/A
Links to CVEs
Test Methodology

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@Ratiranjan5

Copy link
Copy Markdown

CVE-2026-56852:
Patch analysis
Backported: Yes

CVE-2026-56852 affects cert-manager because it bundles vulnerable copies of golang.org/x/text. The vendored versions in the source are v0.21.0 (acmesolver, cainjector, controller, webhook) and v0.16.0 (ctl), both of which fall within the affected range >= 0 and < 0.39.0 (fixed upstream in v0.39.0):
$ grep 'golang.org/x/text' cmd/*/vendor/modules.txt
cmd/acmesolver/vendor/modules.txt:# golang.org/x/text v0.21.0
cmd/cainjector/vendor/modules.txt:# golang.org/x/text v0.21.0
cmd/controller/vendor/modules.txt:# golang.org/x/text v0.21.0
cmd/ctl/vendor/modules.txt:# golang.org/x/text v0.16.0
cmd/webhook/vendor/modules.txt:# golang.org/x/text v0.21.0

  • The affected file unicode/norm/iter.go and the vulnerable function nextComposed() are present in the source code across all five command binaries.

  • The AI patch needed manual rework, as the build failed with it. It modified only three files.

    • cmd/acmesolver/vendor/.../forminfo.go, cmd/acmesolver/vendor/.../iter.go, cmd/webhook/vendor/.../normalize.go.
image
  • Because the isInvalid() definition (in acmesolver/forminfo.go) and its callers (in webhook/normalize.go) ended up in separate trees, the webhook binary failed to compile with info.isInvalid undefined across 9 call sites, while controller, cainjector, and ctl were left completely unpatched and still vulnerable.

Fix:

  • Backported all three upstream file changes consistently into each of the five vendored copies (acmesolver, controller, cainjector, ctl, webhook).
  • The result now it is functionally identical to the upstream fix.
  • The upstream normalize_test.go change was omitted, since vendored code contains no test files.
  • The local build has passed and latest buddy build has been triggered.
  • patch applied during the build (check rpm.log)
  • The SPEC file has been updated to include - bumped up release number, patch file and changelog history.

@Ratiranjan5

Copy link
Copy Markdown

@Kanishk-Bansal
Kanishk-Bansal marked this pull request as ready for review July 27, 2026 16:57
@Kanishk-Bansal
Kanishk-Bansal requested a review from a team as a code owner July 27, 2026 16:57
@jslobodzian
jslobodzian merged commit da0ebf1 into microsoft:fasttrack/3.0 Jul 28, 2026
30 checks passed
@CBL-Mariner-Bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants