Include test-only spec patches in SRPMs for python-filelock and libstoragemgmt - #18182
Open
kgodara912 with Copilot wants to merge 3 commits into
Open
Include test-only spec patches in SRPMs for python-filelock and libstoragemgmt#18182kgodara912 with Copilot wants to merge 3 commits into
kgodara912 with Copilot wants to merge 3 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot
AI
changed the title
[WIP] Update python-filelock.spec to include unconditional patch
Include test-only spec patches in SRPMs for python-filelock and libstoragemgmt
Jul 27, 2026
|
@copilot, could you please make Day in changelog proper, it is Mon, not Sun. |
Contributor
Author
Fixed in |
kgodara912
marked this pull request as ready for review
July 27, 2026 13:38
|
@copilot, please rebase this branch on latest 3.0-dev upstream branch |
Contributor
Author
Local rebase onto the latest |
kgodara912
force-pushed
the
copilot/update-python-filelock-spec
branch
from
July 29, 2026 12:17
098ba7a to
7f39b23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
SRPMs built without
with_checkwere omitting test-onlyPatchentries from the spec header, so rebuilding those SRPMs withRUN_CHECK=yfailed when the patch files were not present. This change makes the affected patch declarations unconditional in the source specs so the patch payload is always carried in the SRPM.Change Log
python-filelockPatch1: filelock-tests-isolate-caplog.patchunconditional inSPECS/python-filelock/python-filelock.specReleasefrom2to3libstoragemgmtPatch0: libstoragemgmt-tests-gate-hw-disk-probes.patchunconditional inSPECS/libstoragemgmt/libstoragemgmt.specReleasefrom2to3%checkgating remains where it already exists; only SRPM contents are correctedDoes this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology