Skip to content

Include test-only spec patches in SRPMs for python-filelock and libstoragemgmt - #18182

Open
kgodara912 with Copilot wants to merge 3 commits into
3.0-devfrom
copilot/update-python-filelock-spec
Open

Include test-only spec patches in SRPMs for python-filelock and libstoragemgmt#18182
kgodara912 with Copilot wants to merge 3 commits into
3.0-devfrom
copilot/update-python-filelock-spec

Conversation

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown
Contributor
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

SRPMs built without with_check were omitting test-only Patch entries from the spec header, so rebuilding those SRPMs with RUN_CHECK=y failed when the patch files were not present. This change makes the affected patch declarations unconditional in the source specs so the patch payload is always carried in the SRPM.

- %if 0%{?with_check}
  Patch1: filelock-tests-isolate-caplog.patch
- %endif
+ Patch1: filelock-tests-isolate-caplog.patch
Change Log
  • python-filelock
    • Make Patch1: filelock-tests-isolate-caplog.patch unconditional in SPECS/python-filelock/python-filelock.spec
    • Bump Release from 2 to 3
    • Add a changelog entry describing the SRPM inclusion fix
  • libstoragemgmt
    • Make Patch0: libstoragemgmt-tests-gate-hw-disk-probes.patch unconditional in SPECS/libstoragemgmt/libstoragemgmt.spec
    • Bump Release from 2 to 3
    • Add a changelog entry describing the SRPM inclusion fix
  • Behavioral impact
    • Test-only patches remain harmless when applied unconditionally
    • %check gating remains where it already exists; only SRPM contents are corrected
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • N/A

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added security 3.0-dev PRs Destined for AzureLinux 3.0 labels Jul 27, 2026
Copilot AI changed the title [WIP] Update python-filelock.spec to include unconditional patch Include test-only spec patches in SRPMs for python-filelock and libstoragemgmt Jul 27, 2026
Copilot AI requested a review from kgodara912 July 27, 2026 13:27
@kgodara912

Copy link
Copy Markdown

@copilot, could you please make Day in changelog proper, it is Mon, not Sun.

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@copilot, could you please make Day in changelog proper, it is Mon, not Sun.

Fixed in 098ba7a.

@kgodara912

Copy link
Copy Markdown

Buddy build

@kgodara912
kgodara912 marked this pull request as ready for review July 27, 2026 13:38
@kgodara912
kgodara912 requested a review from a team as a code owner July 27, 2026 13:38
@kgodara912

Copy link
Copy Markdown

@copilot, please rebase this branch on latest 3.0-dev upstream branch

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot, please rebase this branch on latest 3.0-dev upstream branch

Local rebase onto the latest 3.0-dev completed at 47c8d33, but publishing the rewritten branch failed in the branch-update helper with a signing error. The PR branch on GitHub is still at 098ba7a.

@kgodara912
kgodara912 force-pushed the copilot/update-python-filelock-spec branch from 098ba7a to 7f39b23 Compare July 29, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants