Skip to content

chore: Downmerge main to dev#760

Merged
Avijit-Microsoft merged 17 commits intodevfrom
main
Mar 9, 2026
Merged

chore: Downmerge main to dev#760
Avijit-Microsoft merged 17 commits intodevfrom
main

Conversation

@Ragini-Microsoft
Copy link
Collaborator

Purpose

This pull request introduces several improvements and cleanups to the GitHub Actions workflows for deployment, focusing on modernizing Azure authentication, simplifying runner options, and removing legacy files. The most significant changes are the migration to OIDC-based Azure authentication, the removal of the deprecated "Devcontainer" runner option, and the deletion of the obsolete Windows deployment workflow.

Modernization of Azure authentication:

  • Updated multiple workflows (docker-build.yml, job-cleanup-deployment.yml, job-deploy-linux.yml, deploy-v2.yml) to use OIDC-based Azure authentication via the azure/login@v2 action, replacing service principal logins. This improves security and aligns with best practices. [1] [2] [3] [4] [5]
  • Added id-token: write permission where required for OIDC authentication. [1] [2]

Simplification of runner options:

  • Removed the "Devcontainer" runner option from all relevant workflow inputs and validation logic, leaving only "codespace" and "Local" as valid options. This affects deploy-orchestrator.yml and the renamed deploy-v2.yml. [1] [2] [3] [4]

Workflow cleanups and environment improvements:

  • Added environment: production to several jobs for improved environment tracking and compliance. [1] [2] [3]
  • Removed unnecessary workflow permissions from deploy-orchestrator.yml, job-cleanup-deployment.yml, and job-deploy-linux.yml for cleaner configuration. [1] [2] [3]

Removal of obsolete files:

  • Deleted the entire .github/workflows/deploy-windows.yml workflow, which included extensive input validation and deployment logic for Windows environments, as it is no longer needed.

Ownership and test logic updates:

  • Added a default CODEOWNERS assignment for the repository.
  • Re-enabled E2E tests in deploy-orchestrator.yml by restoring the original conditional logic.

These changes collectively modernize the CI/CD pipeline, reduce complexity, and improve security and maintainability.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants