Skip to content

Add parent trace context information when scheduling an orchestration#358

Merged
bachuv merged 10 commits intomainfrom
vabachu/add-trace-context
Feb 28, 2025
Merged

Add parent trace context information when scheduling an orchestration#358
bachuv merged 10 commits intomainfrom
vabachu/add-trace-context

Conversation

@bachuv
Copy link
Copy Markdown
Contributor

@bachuv bachuv commented Dec 17, 2024

These changes send trace context information (Activity.Current.Id) through the protobuf CreateInstanceRequest.ParentTraceContext field when scheduling a new orchestration instance to help correlate client and orchestrator functions for distributed tracing.

@bachuv bachuv requested a review from jviau January 30, 2025 20:26
@philliphoff
Copy link
Copy Markdown
Member

Also, while this will push the trace context to the backend, and the backend may pass back it back, for example, as part of an activity request, unless the SDK creates an ActivitySource and Activity using that context, worker activity won't be associated with the trace.

@jviau
Copy link
Copy Markdown
Member

jviau commented Feb 11, 2025

Also, while this will push the trace context to the backend, and the backend may pass back it back, for example, as part of an activity request, unless the SDK creates an ActivitySource and Activity using that context, worker activity won't be associated with the trace.

The DurableTask.Core SDK has all of the appropriate ActivitySource's implemented. This SDK will need it added though for customers using the AzureManaged backend.

@bachuv bachuv requested review from jviau and philliphoff February 28, 2025 18:23
@bachuv bachuv merged commit bee3cb8 into main Feb 28, 2025
4 checks passed
@bachuv bachuv deleted the vabachu/add-trace-context branch February 28, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants