Conversation
nytian
commented
Feb 10, 2025
| <configuration> | ||
| <packageSources> | ||
| <clear/> | ||
| <add key="durabletask" value="https://pkgs.dev.azure.com/durabletaskframework/734e7913-2fab-4624-a174-bc57fe96f95d/_packaging/durabletask/nuget/v3/index.json" /> |
Contributor
Author
There was a problem hiding this comment.
remove this as this feed is no longer used
nytian
commented
Feb 10, 2025
| <packageSources> | ||
| <clear/> | ||
| <add key="durabletask" value="https://pkgs.dev.azure.com/durabletaskframework/734e7913-2fab-4624-a174-bc57fe96f95d/_packaging/durabletask/nuget/v3/index.json" /> | ||
| <add key="AzureFunctionsTempStaging" value="https://pkgs.dev.azure.com/azfunc/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/AzureFunctionsTempStaging/nuget/v3/index.json" /> |
Contributor
Author
There was a problem hiding this comment.
we remove this source for durable extension, I guess it should be fine to be removed here too?
nytian
commented
Feb 10, 2025
| <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> | ||
| <IncludeShared>false</IncludeShared> | ||
| <GenerateDocumentationFile>false</GenerateDocumentationFile> | ||
| <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules> |
Contributor
Author
There was a problem hiding this comment.
Added this because there is a build warning. Let me know if this shouldn't be added.
nytian
commented
Feb 10, 2025
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.9.0" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" /> |
Contributor
Author
There was a problem hiding this comment.
this package has been upgrade to 4.9.2 with central package management
nytian
commented
Feb 10, 2025
| <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="3.9.0" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis" Version="3.9.0" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.*" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing" /> |
Contributor
Author
There was a problem hiding this comment.
note: Microsoft.CodeAnalysis.CSharp and Microsoft.CodeAnalysis.CSharp are upgraded to 4.9.2 with central package management
jviau
approved these changes
Feb 11, 2025
Directory.Packages.props
Outdated
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.1" /> |
Member
There was a problem hiding this comment.
What you could do: remove conditions from these outside of here (e.g, line 24 and 53 remove conditions). Then change this to be:
Suggested change
| <PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.1" /> | |
| <PackageVersion Update="Microsoft.Extensions.Hosting" Version="8.0.1" /> |
Contributor
Author
There was a problem hiding this comment.
@jviau how does this update work? I updated this to be like this -- as we only need version v8.0.1 when the tfm is net8
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="6.0.0" Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net48'" />
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.1" Condition="'$(TargetFramework)' == 'net8.0'"/>
…ask-dotnet into nytian/codeql
…ask-dotnet into nytian/codeql
nytian
commented
Feb 12, 2025
nytian
commented
Feb 12, 2025
jviau
reviewed
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.