Fix gRPC channel cache key to include all channel-affecting properties#626
Merged
torosent merged 2 commits intotorosent/fix-grpc-channel-disposefrom Jan 28, 2026
Merged
Conversation
15 tasks
Update cache key generation in both Worker and Client extensions to include all properties that affect CreateChannel behavior: - ResourceId - Credential type (full type name) - AllowInsecureCredentials - WorkerId (Worker only) - RetryOptions (Client only) This ensures that channels are not incorrectly reused when these properties change while EndpointAddress/TaskHubName remain the same. Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on GrpcChannel handle leak in AzureManaged backend
Fix gRPC channel cache key to include all channel-affecting properties
Jan 28, 2026
torosent
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gRPC channel cache key only included
optionsName,EndpointAddress, andTaskHubName, causing stale channels to be reused when other channel-affecting properties changed (e.g., via options reload).Changes
ResourceId, credential type,AllowInsecureCredentials, andWorkerIdResourceId, credential type,AllowInsecureCredentials, andRetryOptions:to\u001F(Unicode unit separator) to avoid collisions with endpoint URIsImpact
Before this fix, changing any of these properties while keeping the same endpoint/task hub would incorrectly reuse the cached channel:
Now each unique configuration creates its own channel as intended.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.