Skip to content

Fix resource leaks in DurableTaskSchedulerWorkerExtensionsTests #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torosent merged 2 commits into from
Jan 28, 2026
Merged

Fix resource leaks in DurableTaskSchedulerWorkerExtensionsTests #627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eb8311
Initial plan
Copilot Jan 28, 2026
f55a0a2
Wrap all ServiceProvider instances in await using to properly dispose…
Copilot Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions test/Worker/AzureManaged.Tests/DurableTaskSchedulerWorkerExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class DurableTaskSchedulerWorkerExtensionsTests
const string ValidTaskHub = "testhub";

[Fact]
public void UseDurableTaskScheduler_WithEndpointAndCredential_ShouldConfigureCorrectly()
public async Task UseDurableTaskScheduler_WithEndpointAndCredential_ShouldConfigureCorrectly()
{
// Arrange
ServiceCollection services = new ServiceCollection();
Expand All @@ -31,7 +31,7 @@ public void UseDurableTaskScheduler_WithEndpointAndCredential_ShouldConfigureCor
mockBuilder.Object.UseDurableTaskScheduler(ValidEndpoint, ValidTaskHub, credential);

// Assert
ServiceProvider provider = services.BuildServiceProvider();
await using ServiceProvider provider = services.BuildServiceProvider();
IOptions<GrpcDurableTaskWorkerOptions>? options = provider.GetService<IOptions<GrpcDurableTaskWorkerOptions>>();
options.Should().NotBeNull();

Expand All @@ -45,7 +45,7 @@ public void UseDurableTaskScheduler_WithEndpointAndCredential_ShouldConfigureCor
}

[Fact]
public void UseDurableTaskScheduler_WithConnectionString_ShouldConfigureCorrectly()
public async Task UseDurableTaskScheduler_WithConnectionString_ShouldConfigureCorrectly()
{
// Arrange
ServiceCollection services = new ServiceCollection();
Expand All @@ -57,7 +57,7 @@ public void UseDurableTaskScheduler_WithConnectionString_ShouldConfigureCorrectl
mockBuilder.Object.UseDurableTaskScheduler(connectionString);

// Assert
ServiceProvider provider = services.BuildServiceProvider();
await using ServiceProvider provider = services.BuildServiceProvider();
IOptions<GrpcDurableTaskWorkerOptions>? options = provider.GetService<IOptions<GrpcDurableTaskWorkerOptions>>();
options.Should().NotBeNull();

Expand All @@ -71,7 +71,7 @@ public void UseDurableTaskScheduler_WithConnectionString_ShouldConfigureCorrectl
}

[Fact]
public void UseDurableTaskScheduler_WithLocalhostConnectionString_ShouldConfigureCorrectly()
public async Task UseDurableTaskScheduler_WithLocalhostConnectionString_ShouldConfigureCorrectly()
{
// Arrange
ServiceCollection services = new();
Expand All @@ -83,7 +83,7 @@ public void UseDurableTaskScheduler_WithLocalhostConnectionString_ShouldConfigur
mockBuilder.Object.UseDurableTaskScheduler(connectionString);

// Assert
ServiceProvider provider = services.BuildServiceProvider();
await using ServiceProvider provider = services.BuildServiceProvider();
IOptions<GrpcDurableTaskWorkerOptions>? options = provider.GetService<IOptions<GrpcDurableTaskWorkerOptions>>();
options.Should().NotBeNull();

Expand All @@ -99,7 +99,7 @@ public void UseDurableTaskScheduler_WithLocalhostConnectionString_ShouldConfigur
[Theory]
[InlineData(null, "testhub")]
[InlineData("myaccount.westus3.durabletask.io", null)]
public void UseDurableTaskScheduler_WithNullParameters_ShouldThrowOptionsValidationException(string? endpoint, string? taskHub)
public async Task UseDurableTaskScheduler_WithNullParameters_ShouldThrowOptionsValidationException(string? endpoint, string? taskHub)
{
// Arrange
ServiceCollection services = new ServiceCollection();
Expand All @@ -109,7 +109,7 @@ public void UseDurableTaskScheduler_WithNullParameters_ShouldThrowOptionsValidat

// Act
mockBuilder.Object.UseDurableTaskScheduler(endpoint!, taskHub!, credential);
ServiceProvider provider = services.BuildServiceProvider();
await using ServiceProvider provider = services.BuildServiceProvider();

// Assert
var action = () => provider.GetRequiredService<IOptions<DurableTaskSchedulerWorkerOptions>>().Value;
Expand All @@ -120,7 +120,7 @@ public void UseDurableTaskScheduler_WithNullParameters_ShouldThrowOptionsValidat
}

[Fact]
public void UseDurableTaskScheduler_WithNullCredential_ShouldSucceed()
public async Task UseDurableTaskScheduler_WithNullCredential_ShouldSucceed()
{
// Arrange
ServiceCollection services = new ServiceCollection();
Expand All @@ -133,7 +133,7 @@ public void UseDurableTaskScheduler_WithNullCredential_ShouldSucceed()
action.Should().NotThrow();

// Validate the configured options
ServiceProvider provider = services.BuildServiceProvider();
await using ServiceProvider provider = services.BuildServiceProvider();
var workerOptions = provider.GetRequiredService<IOptions<DurableTaskSchedulerWorkerOptions>>().Value;
workerOptions.EndpointAddress.Should().Be(ValidEndpoint);
workerOptions.TaskHubName.Should().Be(ValidTaskHub);
Expand Down Expand Up @@ -175,7 +175,7 @@ public void UseDurableTaskScheduler_WithNullOrEmptyConnectionString_ShouldThrowA
}

[Fact]
public void UseDurableTaskScheduler_WithNamedOptions_ShouldConfigureCorrectly()
public async Task UseDurableTaskScheduler_WithNamedOptions_ShouldConfigureCorrectly()
{
// Arrange
ServiceCollection services = new ServiceCollection();
Expand All @@ -188,7 +188,7 @@ public void UseDurableTaskScheduler_WithNamedOptions_ShouldConfigureCorrectly()
mockBuilder.Object.UseDurableTaskScheduler(ValidEndpoint, ValidTaskHub, credential);

// Assert
ServiceProvider provider = services.BuildServiceProvider();
await using ServiceProvider provider = services.BuildServiceProvider();
IOptionsMonitor<DurableTaskSchedulerWorkerOptions>? optionsMonitor = provider.GetService<IOptionsMonitor<DurableTaskSchedulerWorkerOptions>>();
optionsMonitor.Should().NotBeNull();
DurableTaskSchedulerWorkerOptions options = optionsMonitor!.Get("CustomName");
Expand Down Expand Up @@ -264,16 +264,16 @@ public async Task UseDurableTaskScheduler_ServiceProviderDispose_DisposesChannel

// Act
mockBuilder.Object.UseDurableTaskScheduler(ValidEndpoint, ValidTaskHub, credential);
ServiceProvider provider = services.BuildServiceProvider();

// Resolve options to trigger channel creation
IOptionsMonitor<GrpcDurableTaskWorkerOptions> optionsMonitor = provider.GetRequiredService<IOptionsMonitor<GrpcDurableTaskWorkerOptions>>();
GrpcDurableTaskWorkerOptions options = optionsMonitor.Get(Options.DefaultName);
options.Channel.Should().NotBeNull();
GrpcChannel channel = options.Channel!;

// Dispose the service provider - this should dispose the ConfigureGrpcChannel which disposes channels
await provider.DisposeAsync();

GrpcChannel channel;
await using (ServiceProvider provider = services.BuildServiceProvider())
{
// Resolve options to trigger channel creation
IOptionsMonitor<GrpcDurableTaskWorkerOptions> optionsMonitor = provider.GetRequiredService<IOptionsMonitor<GrpcDurableTaskWorkerOptions>>();
GrpcDurableTaskWorkerOptions options = optionsMonitor.Get(Options.DefaultName);
options.Channel.Should().NotBeNull();
channel = options.Channel!;
}

// Assert - verify the channel was disposed by checking it throws ObjectDisposedException
Action action = () => channel.CreateCallInvoker();
Expand Down Expand Up @@ -303,13 +303,13 @@ public async Task UseDurableTaskScheduler_ConfigureAfterDispose_ThrowsObjectDisp

// Act
mockBuilder.Object.UseDurableTaskScheduler(ValidEndpoint, ValidTaskHub, credential);
ServiceProvider provider = services.BuildServiceProvider();

// Resolve options monitor before disposal
IOptionsMonitor<GrpcDurableTaskWorkerOptions> optionsMonitor = provider.GetRequiredService<IOptionsMonitor<GrpcDurableTaskWorkerOptions>>();

// Dispose the service provider
await provider.DisposeAsync();

IOptionsMonitor<GrpcDurableTaskWorkerOptions> optionsMonitor;
await using (ServiceProvider provider = services.BuildServiceProvider())
{
// Resolve options monitor before disposal
optionsMonitor = provider.GetRequiredService<IOptionsMonitor<GrpcDurableTaskWorkerOptions>>();
}

// Assert - attempting to get options after disposal should throw
Action action = () => optionsMonitor.Get(Options.DefaultName);
Expand Down
Loading