fix: Make connection string property key lookup case-insensitive#196
Merged
YunchuWang merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
… lookup Azure connection string keys should be case-insensitive per Azure SDK conventions. The parser stored keys as-is but looked them up by exact case, causing failures when keys used lowercase or mixed casing (e.g. 'endpoint=...' instead of 'Endpoint=...'). Fix: normalize keys to lowercase during parsing and lookup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes #189 by making DurableTaskAzureManagedConnectionString treat connection string property keys case-insensitively, aligning behavior with common Azure SDK conventions while preserving value casing.
Changes:
- Normalize parsed connection string keys to lowercase.
- Perform lookups using lowercase keys.
- Add unit tests covering lowercase/uppercase/mixed-case keys and value-casing preservation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/durabletask-js-azuremanaged/src/connection-string.ts | Lowercases keys during parsing and during property lookup to make key matching case-insensitive. |
| packages/durabletask-js-azuremanaged/test/unit/connection-string.spec.ts | Adds test coverage for case-insensitive key parsing and confirms values keep original casing. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
Verification sample: examples/verification/pr-196-connection-string-case-insensitive.ts Verifies that connection string property keys are parsed case-insensitively, matching Azure SDK conventions. Tests parsing with lowercase, uppercase, mixed-case, and PascalCase keys, plus an end-to-end orchestration using a lowercase connection string against the DTS emulator. Generated by pr-verification-agent Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
added
sample-verification-added
kaibocai
approved these changes
Mar 24, 2026
YunchuWang
deleted the
copilot-finds/bug/fix-connection-string-case-sensitivity
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #189
Problem
DurableTaskAzureManagedConnectionString parses connection string property keys case-sensitively. A connection string with differently-cased keys (e.g., 'endpoint' instead of 'Endpoint') fails validation, violating the Azure SDK convention that connection string property names are case-insensitive.
Changes