Distributed Cache Sync and Atomic Search Param Operations

[SergeyGaluzo]

No description provided.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.01%. Comparing base (2b9e554) to head (cdba4b9).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5479      +/-   ##
==========================================
+ Coverage   76.86%   77.01%   +0.14%     
==========================================
  Files         976      979       +3     
  Lines       35598    35893     +295     
  Branches     5353     5422      +69     
==========================================
+ Hits        27364    27643     +279     
+ Misses       6905     6896       -9     
- Partials     1329     1354      +25     

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SergeyGaluzo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

In general, to fix this kind of issue, we move the filtering condition from inside the loop into a LINQ .Where(...) clause applied to the sequence we’re iterating, optionally projecting into an anonymous type if we need both the original element and extra computed data. This reduces nesting and makes it explicit that we operate only on a subset of the original collection.

Here, instead of looping over all activeHosts and then checking eventsByHosts.TryGetValue(hostName, out var value) && value.Count == 2 && value[0].lastUpdated == value[1].lastUpdated, we can construct an intermediate enumerable that pairs each hostName with its corresponding value (when present), filter that sequence by the same condition, and then populate updatedHosts from it. A good way, without changing functionality, is:

• Keep activeHosts as is.
• Build an enumerable like activeHosts.Select(hostName => new { hostName, value = eventsByHosts.TryGetValue(...) ? value : null }).
• Apply .Where(x => x.value != null && x.value.Count == 2 && x.value[0].lastUpdated == x.value[1].lastUpdated).
• Inside a foreach over this filtered sequence, call updatedHosts.Add(hostName, lastUpdated).

This keeps a single dictionary lookup per host and preserves the semantics of only adding to updatedHosts when the condition holds. The change is local to the loop around lines 286–294 in SqlServerSearchParameterStatusDataStore.cs; all required namespaces (System.Linq) are already imported at the top of the file, so no new imports or methods are needed.