[dev-v5][Chore] Remove PropertyGroup/Target from Charts csproj#4974
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the temporary MSBuild logic in the Charts project that pinned the produced NuGet dependency version range for Microsoft.FluentUI.AspNetCore.Components, reverting the package dependency behavior back to the SDK defaults.
Changes:
- Removed the
FluentUICoreMinVersionproperty used to define a minimum Core dependency range. - Removed the
SetFluentUICoreDependencyVersiontarget that updated_ProjectReferencesWithVersionsduring packing.
dvoituron
approved these changes
Jun 28, 2026
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.5%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed