Skip to content

[dev-v5][Chore] Re-add PropertyGroup/Target to Charts csproj #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 3 commits into from
Jun 29, 2026
Merged

[dev-v5][Chore] Re-add PropertyGroup/Target to Charts csproj #4975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e613aa
Remove PropertyGroup/Target from Charts csproj
vnbaaij Jun 28, 2026
280c637
Undo the csproj change and set min version to a NuGet valid value
vnbaaij Jun 29, 2026
8a83791
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/fix-charts-nuget
vnbaaij Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Charts/Microsoft.FluentUI.AspNetCore.Components.Charts.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,19 @@
<ProjectReference Include="..\Core\Microsoft.FluentUI.AspNetCore.Components.csproj" />
</ItemGroup>

<!-- Pin the minimum published Microsoft.FluentUI.AspNetCore.Components version in the produced nupkg dependencies -->
<!-- NOTE: To be removed when RC4+ is released -->
<PropertyGroup>
<FluentUICoreMinVersion>[5.0.0-rc.1,5.0.0)</FluentUICoreMinVersion>
</PropertyGroup>
<Target Name="SetFluentUICoreDependencyVersion" AfterTargets="_GetProjectReferenceVersions">
<ItemGroup>
<_ProjectReferencesWithVersions Update="@(_ProjectReferencesWithVersions)" Condition="'%(Filename)' == 'Microsoft.FluentUI.AspNetCore.Components'">
<ProjectVersion>$(FluentUICoreMinVersion)</ProjectVersion>
</_ProjectReferencesWithVersions>
</ItemGroup>
</Target>

<!-- Enable deterministic builds for CI environments and Release configuration -->
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true' Or '$(TF_BUILD)' == 'true' Or '$(Configuration)' == 'Release'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
Expand Down
Loading