[dev-v5] Fix FluentLayout header height CSS variable#4977
Merged
dvoituron merged 1 commit intoJun 29, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FluentLayout’s --layout-header-height CSS variable not reflecting FluentLayoutItem.Height for the Header area by ensuring the layout re-renders when items register themselves with the layout container.
Changes:
- Trigger a layout re-render when a
FluentLayoutItemis added to the layout’s internalAreaslist. - Extend the existing layout test to assert the rendered markup includes
--layout-header-heightwith the expected value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Core/Components/Layout/FluentLayoutTests.razor | Adds an assertion that rendered markup contains the expected --layout-header-height CSS variable value. |
| src/Core/Components/Layout/FluentLayout.razor.cs | Calls StateHasChanged() when registering a FluentLayoutItem so CSS variables based on Areas update after items initialize. |
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
vnbaaij
approved these changes
Jun 29, 2026
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.5%
|
dvoituron
deleted the
users/dvoituron/dev-v5/fix-header-height-css-variable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[dev-v5] Fix FluentLayout header height CSS variable
Set the correct value for the
--layout-header-heightCSS variable and ensure the component state updates accordingly.This change improves the layout rendering by correctly applying the header height.
Fix #4976