Skip to content

Comments

chore: migrate to oxfmt#4019

Open
Saadnajmi wants to merge 5 commits intomicrosoft:mainfrom
Saadnajmi:oxfmt
Open

chore: migrate to oxfmt#4019
Saadnajmi wants to merge 5 commits intomicrosoft:mainfrom
Saadnajmi:oxfmt

Conversation

@Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Feb 24, 2026

Description of changes

Following the footsteps of @tido64 in microsoft/react-native-test-app#2681 and microsoft/rnx-kit#3990

Note: Most of this PR (the first 3 commits at least) are mostly entirely AI generated

Verification

CI should pass

The time difference running with lage is nonexistent because it's dominated by the per-package execution. Running prettier * and oxfmt at root though...

prettier at root:
Executed in   26.97 secs

oxfmt at root:
Executed in    1.35 secs 

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: fd42c51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 82 packages
Name Type
@uifabricshared/foundation-composable Patch
@fluentui-react-native/experimental-appearance-additions Patch
@uifabricshared/theming-react-native Patch
@uifabricshared/foundation-settings Patch
@fluentui-react-native/experimental-activity-indicator Patch
@fluentui-react-native/experimental-native-font-metrics Patch
@uifabricshared/foundation-compose Patch
@fluentui-react-native/experimental-native-date-picker Patch
@uifabricshared/foundation-tokens Patch
@fluentui-react-native/eslint-config-rules Patch
@fluentui-react-native/themed-stylesheet Patch
@uifabricshared/themed-settings Patch
@fluentui-react-native/contextual-menu Patch
@uifabricshared/theme-registry Patch
@fluentui-react-native/vibrancy-view Patch
@fluentui-react-native/immutable-merge Patch
@fluentui-react-native/focus-trap-zone Patch
@fluentui-react-native/notification Patch
@uifabricshared/theming-ramp Patch
@fluentui-react-native/experimental-menu-button Patch
@fluentui-react-native/interactive-hooks Patch
@fluentui-react-native/persona-coin Patch
@fluentui-react-native/menu-button Patch
@fluentui-react-native/radio-group Patch
@fluentui-react-native/react-configs Patch
@fluentui-react-native/experimental-checkbox Patch
@fluentui-react-native/dropdown Patch
@fluentui-react-native/experimental-expander Patch
@fluentui-react-native/overflow Patch
@fluentui-react-native/composition Patch
@fluentui-react-native/merge-props Patch
@fluentui-react-native/use-styling Patch
@fluentui-react-native/android-theme Patch
@fluentui-react-native/default-theme Patch
@fluentui-react-native/theming-utils Patch
@fluentui-react-native/focus-zone Patch
@fluentui-react-native/pressable Patch
@fluentui-react-native/separator Patch
@fluentui-react-native/babel-config Patch
@fluentui-react-native/popover Patch
@fluentui-react-native/experimental-shimmer Patch
@fluentui-react-native/spinner Patch
@fluentui-react-native/tooltip Patch
@fluentui-react-native/memo-cache Patch
@fluentui-react-native/use-tokens Patch
@fluentui-react-native/theme-tokens Patch
@fluentui-react-native/checkbox Patch
@fluentui-react-native/jest-config Patch
@fluentui-react-native/experimental-avatar Patch
@fluentui-react-native/drawer Patch
@fluentui-react-native/experimental-shadow Patch
@fluentui-react-native/framework Patch
@fluentui-react-native/use-slots Patch
@fluentui-react-native/apple-theme Patch
@fluentui-react-native/theme-types Patch
@fluentui-react-native/win32-theme Patch
@fluentui-react-native/callout Patch
@fluentui-react-native/divider Patch
@fluentui-react-native/persona Patch
@fluentui-react-native/tablist Patch
@fluentui-react-native/kit-config Patch
@fluentui-react-native/experimental-stack Patch
@fluentui-react-native/use-slot Patch
@fluentui-react-native/avatar Patch
@fluentui-react-native/button Patch
@fluentui-react-native/switch Patch
@fluentui-react-native/badge Patch
@fluentui-react-native/input Patch
@fluentui-react-native/stack Patch
@fluentui-react-native/chip Patch
@fluentui-react-native/icon Patch
@fluentui-react-native/link Patch
@fluentui-react-native/menu Patch
@fluentui-react-native/text Patch
@fluentui-react-native/theme Patch
@fluentui-react-native/framework-base Patch
@fluentui/react-native Patch
@fluentui-react-native/adapters Patch
@fluentui-react-native/styling-utils Patch
@fluentui-react-native/tokens Patch
@fluentui-react-native/codemods Patch
@fluentui-react-native/scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR


1. Installing the Prettier extension for VSCode
2. Going to Settings > Text Editor > Formatting > Check Format On Save
This repo is set up to run [oxfmt](https://oxc.rs/docs/guide/usage/formatter.html). To run oxfmt in fix mode on the repo, run `yarn prettier-fix` at the root of the Repo.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is wrong

examples: [['Format the current package', '$0 format']],
});

fix = Option.Boolean('--fix', false, {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tido64 points out that the underlying thing in prettier is false by default, but true by default with oxfmt

@Saadnajmi
Copy link
Collaborator Author

Note: it is way faster to just run yarn oxfmt at root than to invoke per package with lage..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant