Open
Conversation
The wording removed suggested that a full v9 version was being worked on which created confusion with partners.
gouttierre
added
Fluent UI react-components (v9)
Storybook
Component: Calendar Compat
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Dec 11, 2024
| @@ -28,7 +28,7 @@ yarn workspace @fluentui/react-calendar-compat start | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.Badge Mask RTL.chromium.png | 2 | Changed |
| Avatar Converged.badgeMask.chromium.png | 1 | Changed |
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full.chromium.png | 1154 | Changed |
tudorpopams
approved these changes
Dec 11, 2024
khmakoto
approved these changes
Dec 11, 2024
Member
khmakoto
left a comment
khmakoto
left a comment
There was a problem hiding this comment.
This needs a change file to pass the failing check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording removed suggested that a full v9 version was being worked on which created confusion with partners.
Previous Behavior
The wording suggested that a full v9 version was being worked on which created confusion with partners.
New Behavior
The wording removed suggested should help remove confusion.
Related Issue(s)