Fabric 7: TypeScript 3.5 Updates (WIP)#9298
Closed
JasonGore wants to merge 16 commits intomicrosoft:fabric-7from
JasonGore:jg/ts3-5-rc
Closed
Fabric 7: TypeScript 3.5 Updates (WIP)#9298JasonGore wants to merge 16 commits intomicrosoft:fabric-7from JasonGore:jg/ts3-5-rc
JasonGore wants to merge 16 commits intomicrosoft:fabric-7from
JasonGore:jg/ts3-5-rc
Conversation
JasonGore
requested review from
Jahnp,
KevinTCoughlin,
Markionium,
Vitalius1,
aneeshack4,
atneik,
dzearing,
ecraig12345,
jdhuntington,
jordandrako,
joschect,
kenotron,
khmakoto,
kkjeer,
micahgodbolt,
mtennoe and
srideshpande
as code owners
Contributor
Author
|
Oh I bet it's the shrinkwrap merging that's busting it. Sorry for the noise. |
JasonGore
commented
May 31, 2019
| // IPageSection props with a templated arg rather than just defaulting to string. These | ||
| // issues could probably be more easily found by removing the default TPlatform generic type. | ||
| // To work around this issue for now, a bunch of "as IPageSectionProps[]" casts were added to fabric-website package. | ||
| // export class Page<TPlatform extends string> extends React.Component<IPageProps<TPlatform>, IPageState> { |
Contributor
Author
There was a problem hiding this comment.
@ecraig12345 FYI per our chat. I tried fixing this but it kept propagating. I peppered some as IPageSectionProps[] casts for now.
Contributor
|
Component perf results:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Update Fabric 7 branch to use TS3.5.1. Replacement for #9209.
Microsoft Reviewers: Open in CodeFlow