release-vfsforgit: fix heredoc and add workflow_dispatch trigger#884
Merged
dscho merged 2 commits intovfs-2.53.0from Apr 17, 2026
Merged
release-vfsforgit: fix heredoc and add workflow_dispatch trigger#884dscho merged 2 commits intovfs-2.53.0from
dscho merged 2 commits intovfs-2.53.0from
Conversation
The heredoc used to construct PR_BODY fails in GitHub Actions because the YAML `run: |` block preserves its indentation when passing the script to bash. The closing `EOF` delimiter ends up indented with spaces, but bash's `<<EOF` requires it at column 0 (only `<<-EOF` strips leading whitespace, and only tabs at that). This caused https://github.com/microsoft/git/actions/runs/24558034660/job/71799344023 to fail with "here-document at line 38 delimited by end-of-file (wanted `EOF')". Replace the heredoc with a simple double-quoted string assignment, which works correctly regardless of indentation context. Assisted-by: Claude Opus 4.6 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Add a workflow_dispatch trigger so the workflow can be re-run manually when the release-triggered run fails (as happened in https://github.com/microsoft/git/actions/runs/24558034660/job/71799344023). Without this, the only way to retry is to create a new release. This follows the same pattern as the winget workflow, which already has a workflow_dispatch trigger with a `tag` input. The tag is resolved once in a top-level `env:` block via `${{ github.event.inputs.tag || github.event.release.tag_name }}` so both trigger paths feed the same `TAG_NAME` environment variable. The old `Compute tag name` step and the local `TAG` shell variable are no longer needed. Assisted-by: Claude Opus 4.6 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
Tested successfully: the workflow run completed and created microsoft/VFSForGit#1948. |
dscho
force-pushed
the
fix-release-vfsforgit
branch
from
fb5e2b9 to
aa5b514
Compare
mjcheetham
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the failure in https://github.com/microsoft/git/actions/runs/24558034660/job/71799344023 and adds a
workflow_dispatchtrigger so the workflow can be re-run manually without creating a new release.Commit 1: Replace the broken heredoc (
cat <<EOF) with a simple quoted string. The heredoc failed because the YAMLrun: |block preserves indentation, so the closingEOFdelimiter was never at column 0.Commit 2: Add
workflow_dispatchwith ataginput (same pattern as the winget workflow), and consolidate the tag into a singleTAG_NAMEenv var set at workflow level.