fix: resolve CodeQL quality/maintainability findings#23
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR addresses 5 CodeQL quality/maintainability findings by removing unused imports, variables, and converting a value import to a type-only import where appropriate.
Changes:
- Removed unused schema imports from server.ts (listAdvisoriesSchema, getAdvisorySchema)
- Removed unused OTLPLogExporter import from telemetry.ts (Winston handles logging instead)
- Changed ChildProcess import to type-only import in ai-sdk-azure.test.ts
- Removed unused data variable in test-utils.ts while preserving response body consumption
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/server.ts | Removed unused schema imports; functions are used directly without their schemas |
| src/telemetry.ts | Removed unused OTLPLogExporter import; Winston handles log export instead |
| test/integration/ai-sdk-azure.test.ts | Changed ChildProcess to type-only import (only used in interface definition) |
| test/test-utils.ts | Removed unused data variable while maintaining response body consumption for header access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 5 CodeQL code scanning quality findings from the /security/quality dashboard.
Unused variable/import/function (3 findings)
Useless assignment to local variable (2 findings)
How these findings are reported
These come from CodeQL's extended query suite (maintainability rules). They appear on Security > Code scanning > Quality tab. Rules: js/unused-local-variable, js/useless-assignment-to-local